===================================================================
RCS file: /cvs/trango/Net-Telnet-Trango/scripts/update_trango.pl,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- trango/Net-Telnet-Trango/scripts/update_trango.pl	2005/11/17 20:20:59	1.8
+++ trango/Net-Telnet-Trango/scripts/update_trango.pl	2005/11/18 19:17:12	1.9
@@ -1,5 +1,5 @@
 #!/usr/bin/perl
-# $RedRiver: update_trango.pl,v 1.7 2005/11/17 20:09:45 andrew Exp $
+# $RedRiver: update_trango.pl,v 1.8 2005/11/17 20:20:59 andrew Exp $
 ########################################################################
 # update_trango.pl *** Updates trango foxes with a new firmware
 # 
@@ -8,42 +8,26 @@
 use strict;
 use warnings;
 
-use Net::Telnet;
 use Net::TFTP;
-use Fcntl ':flock'; # import LOCK_* constants
-#use YAML;
-use constant LOG_SAVE => 1;
 
-
 my $config_file = shift || 'update_trango.conf';
-my $max_tries = 1;
+my $max_tries = 3;
 
 
 
+my $l = Mylogger->new( { log_prefix => 'UT' } );
 
 
-
-
-my $log_file =  GetLogName('UT');
-my $MYLOG;  # file handle for logging so we don't have to close and open it all the time
-END {
-  if ($MYLOG) {
-    mylog("Closing log ($log_file)");
-    close $MYLOG;
-  }
-}
-
-
-mylog("Reading config file '$config_file'", LOG_SAVE);
+$l->sp("Reading config file '$config_file'");
 my $conf = read_conf($config_file);
 
-mylog("  Hardware Type: $conf->{'type'}", LOG_SAVE);
-mylog("  File Name:     $conf->{'file_name'}", LOG_SAVE);
-mylog("  File Size:     $conf->{'file_size'}", LOG_SAVE);
-mylog("  File Checksum: $conf->{'file_cksum'}", LOG_SAVE);
-mylog("  FW Version:    $conf->{'ver'}", LOG_SAVE);
-mylog("  FW Checksum:   $conf->{'cksum'}", LOG_SAVE);
-mylog("", LOG_SAVE);
+$l->sp("  Hardware Type: $conf->{'type'}");
+$l->sp("  File Name:     $conf->{'file_name'}");
+$l->sp("  File Size:     $conf->{'file_size'}");
+$l->sp("  File Checksum: $conf->{'file_cksum'}");
+$l->sp("  FW Version:    $conf->{'ver'}");
+$l->sp("  FW Checksum:   $conf->{'cksum'}");
+$l->sp("");
 
 
 
@@ -51,214 +35,403 @@
 
 
 foreach my $fox (@{ $conf->{'ips'} }) {
-  mylog("Updating: $fox", LOG_SAVE);
+  $l->sp("Updating: $fox");
 
   ## Connect and login.
-  my $host = new Net::Telnet (Timeout => 5,
-                              Prompt => '/#> *$/');
-  mylog("Connecting to $fox");
-  unless ( $host->open( Host => $fox, Errmode => 'return') ) {
-    mylog("Couldn't connect to $fox.  Connection timed out.", LOG_SAVE);
-    next;
-  }
-  $host->dump_log('dump.log');
+  my $t = new Trango::Telnet ({
+    Host    => $fox,
+    Timeout => 5,
+  });
 
-  ## Login to remote host.
-  unless ($host->waitfor(
-    -match => '/password: ?$/i',
-    -errmode => "return",
-  ) ) {
-    mylog("problem connecting to host ($fox): " . $host->lastline, LOG_SAVE);
+  $l->p("Connecting to $fox");
+  my ($type, $version) = $t->connect();
+
+  unless (defined $type && defined $version) {
+    $l->sp("Error connecting!");
     next;
   }
 
-  my $login_banner = $host->lastline;
-  my ($type, $version) = $login_banner =~ 
-    /Welcome to Trango Broadband Wireless (\w+)-(.+)$/i;
-
   if ($type ne $conf->{'type'}) {
-    mylog("Wrong type of unit ('$type' should be '$conf->{'type'}')", LOG_SAVE);
-    $host->close;
+    $l->sp("Wrong type of unit ('$type' should be '$conf->{'type'}')");
+    $t->close;
     next;
   }
 
   if ($version eq $conf->{'ver'}) {
-    mylog("Already up to date with firmware version '$version'", LOG_SAVE);
-    $host->close;
+    $l->sp("Already up to date with firmware version '$version'");
+    $t->close;
     next;
   }
 
-  mylog("Logging in");
-  $host->print($conf->{'password'});
-  unless ($host->waitfor(
-    -match => $host->prompt,
-    -errmode => "return",
-  ) ) {
-    mylog("login ($fox) failed: " . $host->lastline);
-    next;
-  }
+  $l->p("Logging in");
+  $t->login($conf->{'password'}) || die "Couldn't login: $!";
 
-
-  mylog("Sending commands");
+  $l->p("Sending commands");
   ## Send commands
-  if ( upload($host, $fox, $conf->{'file_name'}) ) {
-    mylog("Rebooting");
-    $host->print("reboot\n");
-    $host->getline;
+  if ( upload($t, $conf->{'file_name'}) ) {
+    $l->p("Rebooting");
+    $t->reboot;
   } else {
-    mylog("Exiting");
-    $host->print("exit\n");
-    $host->getline;
+    $l->p("Exiting");
+    $t->exit;
   }
-  $host->close;
-  mylog("", LOG_SAVE);
+  $t->close;
+  $l->sp("");
 }
 
 sub upload
 {
-  my $host = shift;
-  my $fox  = shift;
+  my $t    = shift;
   my $file = shift;
 
-  mylog("Getting current version");
-  my $ver = get_ver($host);
+  $l->p("Getting current version");
+  my $ver = $t->ver;
 
   if (
     $ver->{'Firmware Version'}  eq $conf->{'ver'} && 
     $ver->{'Firmware Checksum'} eq $conf->{'cksum'}
   ) {
-    mylog("Already updated!", LOG_SAVE);
+    $l->sp("Already updated!");
     return 1;
   }
 
   my $try = 0;
   while (1) {
     if ($try >= $max_tries) {
-      mylog("Couldn't update in $max_tries tries!");
+      $l->sp("Couldn't update in $max_tries tries!");
       return undef;
     }
     $try++;
 
-    #sysinfo($host);
+    #sysinfo($self->{'_host'});
     
-    mylog("Enabling TFTPd");
-    enable_tftpd($host) || die "Couldn't enable tftpd";
+    $l->p("Enabling TFTPd");
+    $t->enable_tftpd || die "Couldn't enable tftpd";
 
-    mylog("Uploading file ($file)");
+    $l->p("Uploading file ($file)");
     # use tftp to push the file up
-    my $tftp = Net::TFTP->new($fox, Mode => 'octet');
+    my $tftp = Net::TFTP->new($t->Host, Mode => 'octet');
 
     $tftp->put($file, $file) 
       or die "Error uploading: " . $tftp->error;
 
     # waitfor some sort of output
     # make sure it says 'Success.' otherwise error
-    #print "LAST: " . $host->lastline;
-    #my @lines = $host->getlines;
+    #print "LAST: " . $self->lastline;
+    #my @lines = $self->getlines;
     #print Dump \@lines;
     
-    mylog("Checking upload ($conf->{'file_cksum'})");
-    my $results = check_tftpd($host);
+    $l->p("Checking upload ($conf->{'file_cksum'})");
+    my $results = $t->tftpd;
     # check the 'File Length' against ???
     if ( $results->{'File Checksum'} ne $conf->{'file_cksum'}) {
-      mylog("File checksum does not match config file!", LOG_SAVE);
+      $l->sp("File checksum does not match config file!");
       next;
     } 
-    mylog("File checksum ($results->{'File Checksum'}) " . 
+    $l->p("File checksum ($results->{'File Checksum'}) " . 
           "matches ($conf->{'file_cksum'})");
 
     if ($results->{'File Length'}   !~ /^$conf->{'file_size'} bytes/) {
-      mylog("File length does not match config file!", LOG_SAVE);
+      $l->sp("File length does not match config file!");
       next;
     }
-    mylog("File length ($results->{'File Length'}) " . 
+    $l->p("File length ($results->{'File Length'}) " . 
           "matches ($conf->{'file_size'})");
 
     if ( uc($results->{'File Name'}) ne uc($conf->{'file_name'}) ) {
-      mylog("File name does not match config file!", LOG_SAVE);
+      $l->sp("File name does not match config file!");
       next;
     }
-    mylog("File name ($results->{'File Name'}) " . 
+    $l->p("File name ($results->{'File Name'}) " . 
           "matches ($conf->{'file_name'})");
 
-    mylog("Updating flash (new checksum '$conf->{'cksum'}')");
-    $results = updateflash(
-      $host, $ver->{'Firmware Checksum'}, $conf->{'cksum'}
-    ) or die "Couldn't update flash: " . $host->lastline;
+    $l->p("Updating flash (new checksum '$conf->{'cksum'}')");
+    unless ($results = $t->updateflash(
+      $ver->{'Firmware Checksum'}, $conf->{'cksum'}
+    ) ) {
+      $l->sp("Couldn't update flash: $!");
+      next;
+    }
+
     unless (
       defined $results->{'Checksum'} && 
       $results->{'Checksum'} eq $conf->{'cksum'}
     ) {
-      mylog("Saved checksum does not match config file!", LOG_SAVE);
+      $l->sp("Saved checksum does not match config file!");
       next;
     }
-    mylog("Uploaded checksum ($results->{'Checksum'}) " . 
+    $l->p("Uploaded checksum ($results->{'Checksum'}) " . 
           "matches ($conf->{'cksum'})");
     
-    mylog("Successfully updated!", LOG_SAVE);
+    $l->sp("Successfully updated!");
     return 1;
   }
 }
 
-sub get_ver
+sub read_conf
 {
-  my $host = shift;
-  return cmd($host, 'ver');
+  my $file = shift;
+  my %conf;
+  my $in_ip_list = 0;
+  open my $fh, $file or die "Couldn't open file $file: $!";
+  while (<$fh>) {
+    chomp;
+    next if /^#/;
+    next if /^$/;
+    if ($in_ip_list) {
+      if (/^(\d{1,3}\.\d{1,3}\.\d{1,3}\.)(\d{1,3})-(\d{1,3})/) {
+        push @{ $conf{'ips'} }, $1 . $_ for ($2..$3);
+      } else {
+        push @{ $conf{'ips'} }, $_;
+      }
+    } else {
+      my ($key, $val) = split /\s+/, $_, 2;
+
+      if (lc($key) eq 'ips') {
+        $in_ip_list = 1;
+        next;
+      }
+
+      $conf{ lc($key) } = $val;
+    }
+  }
+  close $fh;
+
+  #print Dump \%conf;
+  foreach (
+    'password', 
+    'file_name', 'file_size', 'file_cksum', 
+    'ver', 'cksum', 'ips',
+  ) {
+    die "No $_ specified in config file!"
+      if (not exists $conf{$_});
+  }
+
+  #print Dump \%conf;
+  #exit;
+  return \%conf;
 }
 
-sub enable_tftpd
+package Trango::Telnet;
+use base 'Net::Telnet';
+
+my %PRIVATE = (
+  connected => 0,
+  logged_in => 0,
+);
+
+sub new {
+  my $class = shift;
+  my $args = shift || {};
+
+  $args->{'Timeout'} ||= 5;
+  $args->{'Prompt'}  ||= '/#> *$/';
+
+  foreach my $key (keys %{ $args }) {
+    $PRIVATE{$key} = $args->{$key};
+  }
+
+  my $self = $class->SUPER::new(%{ $args });
+  bless $self;
+
+  #bless $self, $package;
+  return $self;
+}
+
+sub connect
 {
-  my $host = shift;
+  my $self = shift;
 
-  my $vals = cmd($host, 'tftpd on', 'Success.');
+  unless ( $self->open( 
+      Host => $PRIVATE{'Host'},
+      Errmode => 'return',
+  ) ) {
+    $! = "Couldn't connect to $self->{'Host'}.  Connection timed out.";
+    return undef, undef;
+  }
+  #$self->dump_log('dump.log');
 
-  if ($vals->{'Tftpd'} eq 'listen') {
-    return $vals;
-  } else {
+  ## Login to remote host.
+  unless ($self->waitfor(
+    -match => '/password: ?$/i',
+    -errmode => "return",
+  ) ) {
+    $! = "problem connecting to host ($self->{'Host'}): " . $self->lastline;
     return undef;
   }
+
+  $self->login_banner($self->lastline);
+
+  $PRIVATE{'connected'} = 1;
+
+  return ($self->host_type, $self->firmware_version);
 }
 
-sub check_tftpd
+sub login
 {
-  my $host = shift;
-  return cmd($host, 'tftpd', 'Success.');
+  my $self = shift;
+
+  my $password = shift;
+
+  $self->print($password);
+  unless ($self->waitfor(
+    -match => $self->prompt,
+    -errmode => "return",
+  ) ) {
+    $! = "login ($self->{'Host'}) failed: " . $self->lastline;
+    return undef;
+  }
+
+  $PRIVATE{'logged_in'} = 1;
+
+  return 1;
 }
 
+sub login_banner
+{
+  my $self = shift;
+
+  my $banner = shift || $PRIVATE{'login_banner'};
+
+  my ($type, $ver) = $banner =~ 
+    /Welcome to Trango Broadband Wireless (\w+)-(.+)$/i;
+
+  $self->host_type($type);
+  $self->firmware_version($ver); 
+
+  return $banner;
+}
+
+sub host_type 
+{
+  my $self = shift;
+
+  my $type = shift || $PRIVATE{'host_type'};
+  $PRIVATE{'host_type'} = $type;
+
+  return $type;
+}
+
+sub firmware_version
+{
+  my $self = shift;
+
+  my $ver = shift || $PRIVATE{'firmware_version'};
+  $PRIVATE{'firmware_version'} = $ver;
+  
+  return $ver
+}
+
+sub Host
+{
+  my $self = shift;
+  
+  my $host = shift || $PRIVATE{'Host'};
+  $PRIVATE{'HOST'} = $host;
+
+  return $host;
+}
+
+
+sub reboot
+{
+  my $self = shift;
+
+  $self->print("reboot\n");
+  $self->getline;
+
+  return 1;
+}
+
+sub exit
+{
+  my $self = shift;
+
+  $self->print("exit\n");
+  $self->getline;
+
+  return 1;
+}
+
+sub ver
+{
+  my $self = shift;
+
+  return $self->cmd('ver');
+}
+
+sub tftpd
+{
+  my $self = shift;
+
+  return $self->cmd('tftpd', 'Success.');
+}
+
 sub sysinfo
 {
-  my $host = shift;
-  return cmd($host, 'sysinfo', 'Success.');
+  my $self = shift;
+
+  return $self->cmd('sysinfo', 'Success.');
 }
 
+sub enable_tftpd
+{
+  my $self = shift;
+
+  my $vals = $self->cmd('tftpd on', 'Success.');
+
+  if ($vals->{'Tftpd'} eq 'listen') {
+    return $vals;
+  } else {
+    return undef;
+  }
+}
+
 sub updateflash
 {
-  my $host = shift;
+  my $self = shift;
+
   my $old = shift;
   my $new = shift;
 
   return undef unless $new;
 
-  return cmd($host, "updateflash mainimage $old $new", 'Success.', 90);
+  return $self->cmd("updateflash mainimage $old $new", 'Success.', 90);
 }
 
 sub cmd
 {
-  my $host   = shift;
+  my $self = shift;
+
   my $string = shift;
   my $expect_last = shift;
-  my $timeout = shift || 5;
+  my $timeout = shift || $PRIVATE{'Timeout'};
 
-  my @lines = $host->cmd(String => $string, Timeout => $timeout);
+  unless (defined $string) {
+    $! = "No command passed";
+    return undef;
+  }
 
-  my $vals = decode_lines(@lines);
+  unless ($PRIVATE{'connected'}) {
+    $! = "Not connected";
+    return undef;
+  }
 
-  my $last = $host->lastline;
+  unless ($PRIVATE{'logged_in'}) {
+    $! = "Not logged in";
+    return undef;
+  }
 
+  my @lines = $self->SUPER::cmd(String => $string, Timeout => $timeout);
+
+  my $vals = _decode_lines(@lines);
+
   unless ($expect_last) {
     return $vals;
   }
 
+  my $last = $self->lastline;
+
   if ($last =~ /$expect_last$/) {
     return $vals;
   } else {
@@ -267,7 +440,7 @@
   }
 }
 
-sub decode_lines
+sub _decode_lines
 {
   my @lines = @_;
 
@@ -335,68 +508,87 @@
   }
 }
 
-sub read_conf
-{
-  my $file = shift;
-  my %conf;
-  my $in_ip_list = 0;
-  open my $fh, $file or die "Couldn't open file $file: $!";
-  while (<$fh>) {
-    chomp;
-    next if /^#/;
-    next if /^$/;
-    if ($in_ip_list) {
-      if (/^(\d{1,3}\.\d{1,3}\.\d{1,3}\.)(\d{1,3})-(\d{1,3})/) {
-        push @{ $conf{'ips'} }, $1 . $_ for ($2..$3);
-      } else {
-        push @{ $conf{'ips'} }, $_;
-      }
-    } else {
-      my ($key, $val) = split /\s+/, $_, 2;
 
-      if (lc($key) eq 'ips') {
-        $in_ip_list = 1;
-        next;
-      }
 
-      $conf{ lc($key) } = $val;
-    }
-  }
-  close $fh;
+package Mylogger;
 
-  #print Dump \%conf;
-  foreach (
-    'password', 
-    'file_name', 'file_size', 'file_cksum', 
-    'ver', 'cksum', 'ips',
-  ) {
-    die "No $_ specified in config file!"
-      if (not exists $conf{$_});
+use Fcntl ':flock'; # import LOCK_* constants
+#use YAML;
+use constant LOG_PRINT => 128;
+use constant LOG_SAVE  =>  64;
+
+DESTROY {
+  my $self = shift;
+  if ($self->{'MYLOG'}) {
+    $self->p("Closing log ($self->{'log_path'}/$self->{'log_file'})");
+    close $self->{'MYLOG'};
   }
+}
 
-  #print Dump \%conf;
-  #exit;
-  return \%conf;
+sub new {
+  my $package = shift;
+  my $self = shift || {};
+
+  $self->{'base_path'}  ||= '.';
+  $self->{'log_path'}   ||= $self->{'base_path'};
+  $self->{'log_prefix'} ||= 'LOG';
+  $self->{'log_file'}   ||= GetLogName(
+    $self->{'log_prefix'}, 
+    $self->{'log_path'}
+  );
+  bless $self, $package;
 }
 
+sub s
+{
+  my $self = shift;
+  my $m = shift;
+  return $self->mylog($m, LOG_SAVE);
+}
+
+sub p
+{
+  my $self = shift;
+  my $m = shift;
+  return $self->mylog($m, LOG_PRINT);
+}
+
+sub sp
+{
+  my $self = shift;
+  my $m = shift;
+  return $self->mylog($m, LOG_SAVE | LOG_PRINT);
+}
+
 sub mylog
 {
+  my $self = shift;
+
   my $thing = shift;
   chomp $thing;
-  my $save = shift;
 
-  print $thing, "\n";
+  my $which = shift;
 
-  if (defined $save && $save == LOG_SAVE) {
-    unless ($MYLOG) {
-      open ($MYLOG, '>>', $log_file) 
-        or die "Couldn't open logfile!\n";
-      my $ofh = select $MYLOG;
-      $|=1;
-      select $ofh;
-      mylog("Opened log ($log_file)");
-    }
+  my $MYLOG;
+  if ($which & LOG_PRINT) {
+    print $thing, "\n";
+  }
 
+  if ($which & LOG_SAVE) {
+    if ($self->{'MYLOG'}) {
+      $MYLOG = $self->{'MYLOG'};
+    } else {
+      unless ($MYLOG) {
+		open ($MYLOG, '>>', $self->{'log_path'} . '/' . $self->{'log_file'}) 
+          or die "Couldn't open logfile!\n";
+        my $ofh = select $MYLOG;
+        $|=1;
+        select $ofh;
+        $self->{'MYLOG'} = $MYLOG;
+
+        $self->p("Opened log ($self->{'log_path'}/$self->{'log_file'})");
+      }
+    }
     flock($MYLOG, LOCK_EX);
     print $MYLOG (scalar gmtime), "\t", $thing, "\n" 
       or die "Couldn't print to MYLOG: $!";