=================================================================== RCS file: /cvs/todotxt/Text-Todo/lib/Text/Todo/Entry.pm,v retrieving revision 1.13 retrieving revision 1.18 diff -u -r1.13 -r1.18 --- todotxt/Text-Todo/lib/Text/Todo/Entry.pm 2010/01/10 01:03:02 1.13 +++ todotxt/Text-Todo/lib/Text/Todo/Entry.pm 2010/01/11 01:30:24 1.18 @@ -1,6 +1,6 @@ package Text::Todo::Entry; -# $RedRiver: Entry.pm,v 1.12 2010/01/10 00:13:14 andrew Exp $ +# $RedRiver: Entry.pm,v 1.16 2010/01/10 22:49:53 andrew Exp $ use warnings; use strict; @@ -20,14 +20,12 @@ my %known_tags_of; # XXX Should the completion (x) be case sensitive? - my $priority_completion_regex = qr/ + my $priority_completion_regex = qr{ ^ \s* - (?i: (x) \s+)? - (?i:\( ([A-Z]) \) \s+)? - /xms; + (?i:(x \s* [\d-]* ) \s*)? + (?i:\( ([A-Z]) \) \s*)? + }xms; - sub replace { _update_entry(@_) } - sub new { my ( $class, $options ) = @_; @@ -73,12 +71,12 @@ } } - $self->_update_entry( $options->{text} ); + $self->replace( $options->{text} ); return $self; } - sub _update_entry { + sub replace { my ( $self, $text ) = @_; my $ident = ident($self); @@ -89,14 +87,40 @@ foreach my $tag ( keys %{ $known_tags_of{$ident} } ) { my $symbol = quotemeta $known_tags_of{$ident}{$tag}; $tags_of{$ident}{$tag} = { map { $_ => q{} } - $text =~ / (?:^|\s) $symbol (\S+)/gxms }; + $text =~ / (?:^|\s) $symbol (\S*)/gxms }; } - ( $completion_status_of{$ident}, $priority_of{$ident} ) + my ( $completed, $priority ) = $text =~ / $priority_completion_regex /xms; + $completion_status_of{$ident} = _clean_completed($completed); + $priority_of{$ident} = $priority; + return 1; } + sub _clean_completed { + my ($completed) = @_; + + $completed ||= q{}; + $completed =~ s/^\s+|\s+$//gxms; + + if ( !$completed ) { + return; + } + + if ( $completed =~ s/(x)\s*//ixms ) { + my $status = $1; + if ($completed) { + return $completed; + } + else { + return $status; + } + } + + return; + } + sub _tags { my ( $self, $tag ) = @_; my $ident = ident($self); @@ -117,7 +141,7 @@ return $text_of{$ident}; } - sub depri { pri( $_[0], '' ) } + sub depri { my ($self) = @_; return $self->pri(q{}) } sub pri { my ( $self, $new_pri ) = @_; @@ -148,6 +172,9 @@ $new =~ s/$priority_completion_regex//xms; if ( $self->done ) { + if ($self->done !~ /^x/ixms) { + push @new, 'x'; + } push @new, $self->done; } @@ -159,15 +186,17 @@ push @new, $addition; } - return $self->_update_entry( join q{ }, @new, $new ); + return $self->replace( join q{ }, @new, $new ); } sub append { my ( $self, $addition ) = @_; - return $self->_update_entry( join q{ }, $self->text, $addition ); + return $self->replace( join q{ }, $self->text, $addition ); } - sub do { + ## no critic 'homonym' + sub do { # This is what it is called in todo.sh + ## use critic my ($self) = @_; my $ident = ident($self); @@ -175,7 +204,10 @@ return 1; } - $completion_status_of{$ident} = 'x'; + $completion_status_of{$ident} = sprintf "%04d-%02d-%02d", + ( (localtime)[5] + 1900 ), + ( (localtime)[4] + 1 ), + ( (localtime)[3] ); return $self->prepend(); } @@ -201,7 +233,7 @@ Since the $VERSION can't be automatically included, here is the RCS Id instead, you'll have to look up $VERSION. - $Id: Entry.pm,v 1.13 2010/01/10 01:03:02 andrew Exp $ + $Id: Entry.pm,v 1.18 2010/01/11 01:30:24 andrew Exp $ =head1 SYNOPSIS @@ -360,16 +392,19 @@ $entry->do; -Does this by prepending an 'x' to the beginning of the entry. +Does this by prepending "x `date '%Y-%m-%d'`" to the beginning of the entry. =head2 done Returns true if an entry is marked complete and false if not. - - if (!$entry->done) { + + if (!my $status = $entry->done) { # remind me to do it } +If the entry starts as 'x date', for example 'x 2010-01-01', $status is now +'2010-01-01'. +If the entry just starts with 'x', then $status will be 'x'. =head1 DIAGNOSTICS