===================================================================
RCS file: /cvs/openbsd/sxxu/Attic/install.sxxu,v
retrieving revision 1.13
retrieving revision 1.17
diff -u -r1.13 -r1.17
--- openbsd/sxxu/Attic/install.sxxu	2010/04/22 23:01:41	1.13
+++ openbsd/sxxu/Attic/install.sxxu	2010/04/23 22:14:22	1.17
@@ -1,5 +1,5 @@
 #!/bin/ksh -
-# $Id: install.sxxu,v 1.13 2010/04/22 22:01:41 andrew Exp $
+# $Id: install.sxxu,v 1.17 2010/04/23 21:14:22 andrew Exp $
 
 # Copyright (c) 2010 Andrew Fresh <andrew@afresh1.com>
 #
@@ -25,11 +25,11 @@
 export PKG_PATH
 
 do_pre() {
-    # nothing to do
+    echo 'Running post install from sxxu'
 }
 
 do_post() {
-    # nothing to do
+    echo 'See /var/log/install.log for install messages.'
 }
 
 process_roles() {
@@ -42,12 +42,15 @@
     fi
 
     local _roles
+    unset _roles
     set -A _roles
     local _role
     while read _role; do
-	if [ -n "${_role}" ]; then
-        	_roles[${#_roles[@]}]="$_role"
-	fi
+    if [ -n "${_role}" ]; then
+            _line=${_line%%#*}              # strip comments
+            test -z "$_line" && continue
+            _roles[${#_roles[@]}]="$_role"
+    fi
     done < roles
     
     for _role in "${_roles[@]}"; do
@@ -64,12 +67,15 @@
     echo ' ==> Setting PKG_PATH'
     local _line
     while read _line; do
+        _line=${_line%%#*}              # strip comments
+        test -z "$_line" && continue
         if [ -z "${PKG_PATH}" ]; then
             PKG_PATH="$_line"
         else
             PKG_PATH="${PKG_PATH}:${_line}"
         fi
     done < pkg_path
+
     PKG_PATH=`eval echo $PKG_PATH`
 }
 
@@ -84,9 +90,11 @@
         echo " ==> Running $_cmd $_args"
         local _line
         while read _line; do
-            echo "  => ${_line}"
+            _line=${_line%%#*}              # strip comments
+            test -z "$_line" && continue
+            echo "  => ${_cmd} ${_args} ${_line}"
             eval ${_cmd} ${_args} ${_line}
-        done < ${_f}
+        done < "${_f}"
     done
 }
 
@@ -101,7 +109,7 @@
         # -N Always assume a forward patch.
         # -t Never prompt; assume the user is expert
         # -p0 full path, always
-        patch -N -t -p0 -d / < $_p
+        patch -N -t -p0 -d / < "$_p"
     done
 }
 
@@ -123,7 +131,7 @@
         return
     fi
 
-    echo "===> Applying ${_role}"
+    echo "===> Applying role ${_role}"
 
     cd "${_rolepwd}"
     if [ -e ./siteXXrc ]; then
@@ -158,5 +166,4 @@
 
 do_pre        2>&1 | /usr/bin/tee    /var/log/install.log
 process_roles 2>&1 | /usr/bin/tee -a /var/log/install.log | grep '^...>'
-do_post       2>&1 | /usr/bin/tee -a /var/log/install.log | grep '^...>'
-echo See /var/log/install.log for install messages.
+do_post       2>&1 | /usr/bin/tee -a /var/log/install.log