===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.83
retrieving revision 1.95
diff -u -r1.83 -r1.95
--- openbsd/fw_update/fw_install.sh	2021/12/18 20:19:02	1.83
+++ openbsd/fw_update/fw_install.sh	2021/12/21 02:16:47	1.95
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.83 2021/12/18 20:19:02 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.95 2021/12/21 02:16:47 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -15,7 +15,8 @@
 # ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
-set -o errexit -o pipefail -o nounset
+set -o errexit -o pipefail -o nounset -o noclobber -o noglob
+set +o monitor
 export PATH=/usr/bin:/bin:/usr/sbin:/sbin
 
 CFILE=SHA256.sig
@@ -33,6 +34,8 @@
 FWURL=http://firmware.openbsd.org/firmware/${HTTP_FWDIR}
 FWPUB_KEY=${DESTDIR}/etc/signify/openbsd-${VERSION}-fw.pub
 
+DOWNLOAD=true
+INSTALL=true
 LOCALSRC=
 
 tmpdir() {
@@ -52,23 +55,52 @@
 }
 
 fetch() {
-	local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _exit
+	local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _pid _exit _error=''
 
 	# If we're not in the installer,
 	# we have su(1) and doas(1) is unlikely to be configured.
+	set -o monitor # make sure ftp gets its own process group
+	(
 	if [ -x /usr/bin/su ]; then
-		/usr/bin/su -s /bin/ksh "$_user" -c \
+		exec /usr/bin/su -s /bin/ksh "$_user" -c \
 		    "/usr/bin/ftp -D 'Get/Verify' -Vm -o- '$_src'" > "$_dst"
-		_exit="$?"
 	else
-		/usr/bin/doas -u "$_user" \
+		exec /usr/bin/doas -u "$_user" \
 		    /usr/bin/ftp -D 'Get/Verify' -Vm -o- "$_src" > "$_dst"
-		_exit="$?"
 	fi
+	) & _pid=$!
+	set +o monitor
 
+	trap "kill -TERM '-$_pid'; exit 1" EXIT INT QUIT ABRT TERM
+
+	SECONDS=0
+	_last=0
+	while kill -0 -"$_pid" 2>/dev/null; do
+		if [[ $SECONDS -gt 12 ]]; then
+			set -- $( ls -ln "$_dst" 2>/dev/null )
+			if [[ $_last -ne $5 ]]; then
+				_last=$5
+				SECONDS=0
+				sleep 1
+			else
+				kill -INT -"$_pid"
+				_error=" (timed out)"
+			fi
+		else
+			sleep 1
+		fi
+	done
+
+	set +o errexit
+	wait "$_pid"
+	_exit=$?
+	set -o errexit
+
+	trap "" EXIT INT QUIT ABRT TERM
+
 	if [ "$_exit" -ne 0 ]; then
 		rm -f "$_dst"
-		echo "Cannot fetch $_src" >&2
+		echo "Cannot fetch $_src$_error" >&2
 		return 1
 	fi
 }
@@ -82,37 +114,24 @@
 }
 
 devices_needing_firmware() {
-	local _d _m _line _dmesgtail _last=''
+	local _d _m _line _dmesgtail _last='' _nl=$( echo )
 
 	# When we're not in the installer, the dmesg.boot can
 	# contain multiple boots, so only look in the last one
-	sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot | { \
-		_m=0
-		set -A _dmesgtail
-		while read -r _line; do
-			_dmesgtail[$_m]="$_line"
-			let _m=$_m+1
-		done
+	_dmesgtail="$( echo ; sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot |
+	    grep -e "^[a-z][a-z]*[0-9]" -e " not configured " )"
 
-		grep -v '^[[:space:]]*#' "$FWPATTERNS" |
-		    while read -r _d _m; do
-			[ "$_d" = "$_last" ] && continue
-			[ "$_m" ] || _m="^${_d}[0-9] at "
+	grep -v '^[[:space:]]*#' "$FWPATTERNS" |
+	    while read -r _d _m; do
+		[ "$_d" = "$_last" ] && continue
+		[ "$_m" ]             || _m="${_nl}${_d}[0-9] at "
+		[ "$_m" = "${_m#^}" ] || _m="${_nl}${_m#^}"
 
-			if [ "$_m" = "${_m#^}" ]; then
-				_m="*$_m"
-			else
-				_m="${_m#^}"
-			fi
-
-			for _line in "${_dmesgtail[@]}"; do
-				if [[ $_line = ${_m}* ]]; then
-					echo "$_d"
-					_last="$_d"
-				fi
-			done
-		    done
-	}
+		if [[ $_dmesgtail = *$_m* ]]; then
+			echo "$_d"
+			_last="$_d"
+		fi
+	    done
 }
 
 firmware_filename() {
@@ -129,10 +148,12 @@
 }
 
 installed_firmware() {
+	set +o noglob
 	for fw in "${DESTDIR}/var/db/pkg/$1-firmware"*; do
 		[ -e "$fw" ] || continue
 		echo "${fw##*/}"
 	done
+	set -o noglob
 }
 
 add_firmware () {
@@ -180,7 +201,9 @@
 		if [ -d "$_r" ]; then
 			# Try hard not to actually remove recursively
 			# without rmdir on the install media.
+			set +o noglob
 			[ "$_r/*" = "$( echo "$_r"/* )" ] && rm -rf "$_r"
+			set -o noglob
 		else
 			rm -f "$_r"
 		fi
@@ -188,40 +211,52 @@
 }
 
 usage() {
-	echo "usage: fw_install [-DL] [driver | file [...]]"
+	echo "usage:  ${0##*/} [-D | -L] [driver | file ...]"
 	exit 2
 }
 
-INSTALL=true
-DOWNLOAD=true
-
+OPT_D=
+OPT_L=
 while getopts DL name
 do
        case "$name" in
-       # "download only" means local dir and don't install
-       D) LOCALSRC=. INSTALL=false ;;
-       L) LOCALSRC=. ;;
+       D) OPT_D=true ;;
+       L) OPT_L=true ;;
        ?) usage 2 ;;
        esac
 done
 shift $((OPTIND - 1))
 
-# If we're installing from a local dir
-# we don't want to download anything
-[ "$LOCALSRC" ] && "$INSTALL" && DOWNLOAD=false
-[ "$LOCALSRC" ] || LOCALSRC="$( tmpdir "${DESTDIR}/tmp/fw_install" )"
+[ "$OPT_D" ] && [ "$OPT_L" ] && usage 1
 
+if [ "$OPT_D" ]; then
+	# "Download only" means local dir and don't install
+	INSTALL=false
+	LOCALSRC=.
+elif [ "$OPT_L" ]; then
+	# "Local" means don't download, install from local dir
+	DOWNLOAD=false
+	LOCALSRC=.
+else
+	LOCALSRC="$( tmpdir "${DESTDIR}/tmp/fw_install" )"
+fi
+
 CFILE="$LOCALSRC/$CFILE"
 
+if "$INSTALL" && [ -x /usr/bin/id ] && [ $(/usr/bin/id -u) != 0 ]; then
+	echo "need root privileges" >&2
+	exit 1
+fi
+
 set -A devices -- "$@"
 
-[ "${devices[*]:-}" ] ||
-    set -A devices -- $( devices_needing_firmware )
-
 if [ ! "${devices[*]:-}" ]; then
-	echo "No devices found which need firmware files to be downloaded."
-	exit
+	echo -n "Detecting firmware ..."
+	set -A devices -- $( devices_needing_firmware )
+	[ "${devices[*]:-}" ] && echo " found." || echo " done."
 fi
+
+[ "${devices[*]:-}" ] || exit
 
 if "$DOWNLOAD"; then
 	fetch "$CFILE"