===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.70
retrieving revision 1.83
diff -u -r1.70 -r1.83
--- openbsd/fw_update/fw_install.sh	2021/12/11 05:35:21	1.70
+++ openbsd/fw_update/fw_install.sh	2021/12/18 20:19:02	1.83
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.70 2021/12/11 05:35:21 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.83 2021/12/18 20:19:02 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -16,6 +16,7 @@
 # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 set -o errexit -o pipefail -o nounset
+export PATH=/usr/bin:/bin:/usr/sbin:/sbin
 
 CFILE=SHA256.sig
 DESTDIR=${DESTDIR:-}
@@ -38,7 +39,7 @@
 	local _i=1 _dir
 
 	# If we're not in the installer,
-	# we have mktemp and a more hostile environment
+	# we have mktemp and a more hostile environment.
 	if [ -x /usr/bin/mktemp ]; then
 		_dir=$( mktemp -d "${1}-XXXXXXXXX" )
 	else
@@ -53,8 +54,8 @@
 fetch() {
 	local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _exit
 
-	# If we're not in the installer, we have su(1)
-	# and doas(1) is unlikely to be configured.
+	# If we're not in the installer,
+	# we have su(1) and doas(1) is unlikely to be configured.
 	if [ -x /usr/bin/su ]; then
 		/usr/bin/su -s /bin/ksh "$_user" -c \
 		    "/usr/bin/ftp -D 'Get/Verify' -Vm -o- '$_src'" > "$_dst"
@@ -81,23 +82,37 @@
 }
 
 devices_needing_firmware() {
-	local _d _m _grep _dmesgtail _last=''
+	local _d _m _line _dmesgtail _last=''
 
 	# When we're not in the installer, the dmesg.boot can
 	# contain multiple boots, so only look in the last one
-	_dmesgtail=$( sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot )
+	sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot | { \
+		_m=0
+		set -A _dmesgtail
+		while read -r _line; do
+			_dmesgtail[$_m]="$_line"
+			let _m=$_m+1
+		done
 
-	grep -v '^[[:space:]]*#' "$FWPATTERNS" |
-	    while read -r _d _m; do
-		_grep="grep"
-		[ "$_last" = "$_d" ] && continue
-		[ "$_m" ] || _m="^${_d}[0-9][0-9]* at "
-		[ "$_m" = "${_m#^}" ] && _grep="fgrep"
+		grep -v '^[[:space:]]*#' "$FWPATTERNS" |
+		    while read -r _d _m; do
+			[ "$_d" = "$_last" ] && continue
+			[ "$_m" ] || _m="^${_d}[0-9] at "
 
-		echo "$_dmesgtail" | $_grep -q "$_m" || continue
-		echo "$_d"
-		_last="$_d"
-	done
+			if [ "$_m" = "${_m#^}" ]; then
+				_m="*$_m"
+			else
+				_m="${_m#^}"
+			fi
+
+			for _line in "${_dmesgtail[@]}"; do
+				if [[ $_line = ${_m}* ]]; then
+					echo "$_d"
+					_last="$_d"
+				fi
+			done
+		    done
+	}
 }
 
 firmware_filename() {
@@ -121,14 +136,15 @@
 }
 
 add_firmware () {
-	local _f="${1##*/}" _pkgdir="${DESTDIR}/var/db/pkg"
+	local _f="${1##*/}"
+	local _pkgdir="${DESTDIR}/var/db/pkg/${_f%.tgz}"
 	ftp -D "Install" -Vmo- "file:${1}" |
-		tar -s ",^\+,${_pkgdir}/${_f%.tgz}/+," \
+		tar -s ",^\+,${_pkgdir}/+," \
 		    -s ",^firmware,${DESTDIR}/etc/firmware," \
 		    -C / -zxphf - "+*" "firmware/*"
 
 	# TODO: Should we mark these so real fw_update can -Drepair?
-	ed -s "${_pkgdir}/${_f%.tgz}/+CONTENTS" <<EOL
+	ed -s "${_pkgdir}/+CONTENTS" <<EOL
 /^@comment pkgpath/ -1a
 @option manual-installation
 @option firmware
@@ -172,18 +188,18 @@
 }
 
 usage() {
-	echo "usage: fw_install [-d dir | -L dir] [driver | file [...]]"
+	echo "usage: fw_install [-DL] [driver | file [...]]"
 	exit 2
 }
 
 INSTALL=true
 DOWNLOAD=true
 
-while getopts dL name
+while getopts DL name
 do
        case "$name" in
        # "download only" means local dir and don't install
-       d) LOCALSRC=. INSTALL=false ;;
+       D) LOCALSRC=. INSTALL=false ;;
        L) LOCALSRC=. ;;
        ?) usage 2 ;;
        esac
@@ -195,6 +211,8 @@
 [ "$LOCALSRC" ] && "$INSTALL" && DOWNLOAD=false
 [ "$LOCALSRC" ] || LOCALSRC="$( tmpdir "${DESTDIR}/tmp/fw_install" )"
 
+CFILE="$LOCALSRC/$CFILE"
+
 set -A devices -- "$@"
 
 [ "${devices[*]:-}" ] ||
@@ -205,7 +223,7 @@
 	exit
 fi
 
-if "$DOWNLOAD" && ! [[ -e "$CFILE" ]]; then
+if "$DOWNLOAD"; then
 	fetch "$CFILE"
 	! signify -qVep "$FWPUB_KEY" -x "$CFILE" -m "$CFILE" &&
 	    echo "Signature check of SHA256.sig failed" >&2 && exit 1
@@ -218,7 +236,7 @@
 		f=$( firmware_filename "$d" || true )
 		[ "$f" ] || continue
 		f="$LOCALSRC/$f"
-	elif ! "$INSTALL" && ! grep -q "($f)" "$CFILE" ; then
+	elif ! "$INSTALL" && ! grep -Fq "($f)" "$CFILE" ; then
 		echo "Cannot download local file $f" >&2
 		exit 2
 	fi
@@ -234,14 +252,18 @@
 		done
 	fi
 
-	if [ ! -e "$f" ]; then
-		"$INSTALL" && ! "$DOWNLOAD" &&
-		    echo "Cannot install ${f##*/}, not found" >&2 && continue
+	if [ -e "$f" ]; then
+		if "$DOWNLOAD"; then
+			echo "Verify existing ${f##*/}"
+			verify "$f" || continue
+		# else assume it was verified when downloaded
+		fi
+	elif "$DOWNLOAD"; then
 		fetch  "$f" || continue
 		verify "$f" || continue
-	elif $DOWNLOAD; then
-		echo "Already have $f"
-		verify "$f" || continue
+	elif "$INSTALL"; then
+		echo "Cannot install ${f##*/}, not found" >&2
+		continue
 	fi
 
 	"$INSTALL" || continue