=================================================================== RCS file: /cvs/openbsd/fw_update/fw_install.sh,v retrieving revision 1.74 retrieving revision 1.136 diff -u -r1.74 -r1.136 --- openbsd/fw_update/fw_install.sh 2021/12/11 20:57:51 1.74 +++ openbsd/fw_update/fw_install.sh 2021/12/25 20:48:40 1.136 @@ -1,5 +1,5 @@ #!/bin/ksh -# $OpenBSD: fw_install.sh,v 1.74 2021/12/11 20:57:51 afresh1 Exp $ +# $OpenBSD: fw_install.sh,v 1.136 2021/12/25 20:48:40 afresh1 Exp $ # # Copyright (c) 2021 Andrew Hewus Fresh # @@ -15,7 +15,9 @@ # ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. -set -o errexit -o pipefail -o nounset +set -o errexit -o pipefail -o nounset -o noclobber -o noglob +set +o monitor +export PATH=/usr/bin:/bin:/usr/sbin:/sbin CFILE=SHA256.sig DESTDIR=${DESTDIR:-} @@ -32,13 +34,29 @@ FWURL=http://firmware.openbsd.org/firmware/${HTTP_FWDIR} FWPUB_KEY=${DESTDIR}/etc/signify/openbsd-${VERSION}-fw.pub +DRYRUN=false +VERBOSE=false +DELETE=false +DOWNLOAD=true +INSTALL=true LOCALSRC= +unset FTPPID +unset FWPKGTMP +REMOVE_LOCALSRC=false +cleanup() { + set +o errexit # ignore errors from killing ftp + [ "${FTPPID:-}" ] && kill -TERM -"$FTPPID" 2>/dev/null + [ "${FWPKGTMP:-}" ] && rm -rf "$FWPKGTMP" + "$REMOVE_LOCALSRC" && rm -rf "$LOCALSRC" +} +trap cleanup EXIT + tmpdir() { local _i=1 _dir # If we're not in the installer, - # we have mktemp and a more hostile environment + # we have mktemp and a more hostile environment. if [ -x /usr/bin/mktemp ]; then _dir=$( mktemp -d "${1}-XXXXXXXXX" ) else @@ -51,23 +69,52 @@ } fetch() { - local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _exit + local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _exit _error='' - # If we're not in the installer, we have su(1) - # and doas(1) is unlikely to be configured. + # If we're not in the installer, + # we have su(1) and doas(1) is unlikely to be configured. + set -o monitor # make sure ftp gets its own process group + ( + flags=-VM + "$VERBOSE" && flags=-vm if [ -x /usr/bin/su ]; then - /usr/bin/su -s /bin/ksh "$_user" -c \ - "/usr/bin/ftp -D 'Get/Verify' -Vm -o- '$_src'" > "$_dst" - _exit="$?" + exec /usr/bin/su -s /bin/ksh "$_user" -c \ + "/usr/bin/ftp -N '${0##/}' -D 'Get/Verify' $flags -o- '$_src'" > "$_dst" else - /usr/bin/doas -u "$_user" \ - /usr/bin/ftp -D 'Get/Verify' -Vm -o- "$_src" > "$_dst" - _exit="$?" + exec /usr/bin/doas -u "$_user" \ + /usr/bin/ftp -N "${0##/}" -D 'Get/Verify' $flags -o- "$_src" > "$_dst" fi + ) & FTPPID=$! + set +o monitor + SECONDS=0 + _last=0 + while kill -0 -"$FTPPID" 2>/dev/null; do + if [[ $SECONDS -gt 12 ]]; then + set -- $( ls -ln "$_dst" 2>/dev/null ) + if [[ $_last -ne $5 ]]; then + _last=$5 + SECONDS=0 + sleep 1 + else + kill -INT -"$FTPPID" + _error=" (timed out)" + fi + else + sleep 1 + fi + done + + set +o errexit + wait "$FTPPID" + _exit=$? + set -o errexit + + unset FTPPID + if [ "$_exit" -ne 0 ]; then rm -f "$_dst" - echo "Cannot fetch $_src" >&2 + echo "Cannot fetch $_src$_error" >&2 return 1 fi } @@ -80,24 +127,24 @@ fi } -devices_needing_firmware() { - local _d _m _grep _dmesgtail _last='' +firmware_in_dmesg() { + local _d _m _line _dmesgtail _last='' _nl=$( echo ) # When we're not in the installer, the dmesg.boot can # contain multiple boots, so only look in the last one - _dmesgtail=$( sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot ) + _dmesgtail="$( echo ; sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot )" grep -v '^[[:space:]]*#' "$FWPATTERNS" | while read -r _d _m; do - _grep="grep" - [ "$_last" = "$_d" ] && continue - [ "$_m" ] || _m="^${_d}[0-9][0-9]* at " - [ "$_m" = "${_m#^}" ] && _grep="fgrep" + [ "$_d" = "$_last" ] && continue + [ "$_m" ] || _m="${_nl}${_d}[0-9] at " + [ "$_m" = "${_m#^}" ] || _m="${_nl}${_m#^}" - echo "$_dmesgtail" | $_grep -q "$_m" || continue - echo "$_d" - _last="$_d" - done + if [[ $_dmesgtail = *$_m* ]]; then + echo "$_d" + _last="$_d" + fi + done } firmware_filename() { @@ -114,22 +161,60 @@ } installed_firmware() { - for fw in "${DESTDIR}/var/db/pkg/$1-firmware"*; do - [ -e "$fw" ] || continue + local _pre="$1" _match="$2" _post="$3" _firmware + set -sA _firmware -- $( + set +o noglob + grep -Fxl '@option firmware' \ + "${DESTDIR}/var/db/pkg/"$_pre"$_match"$_post"/+CONTENTS" \ + 2>/dev/null || true + set -o noglob + ) + + [ "${_firmware[*]:-}" ] || return 0 + for fw in "${_firmware[@]}"; do + fw="${fw%/+CONTENTS}" echo "${fw##*/}" done } +detect_firmware() { + local _devices _last='' _d + + set -sA _devices -- $( + firmware_in_dmesg + for _d in $( installed_firmware '*' '-firmware-' '*' ); do + firmware_devicename "$_d" + done + ) + + [ "${_devices[*]:-}" ] || return 0 + for _d in "${_devices[@]}"; do + [ "$_last" = "$_d" ] && continue + echo "$_d" + _last="$_d" + done +} + add_firmware () { - local _f="${1##*/}" - local _pkgdir="${DESTDIR}/var/db/pkg/${_f%.tgz}" - ftp -D "Install" -Vmo- "file:${1}" | - tar -s ",^\+,${_pkgdir}/+," \ + local _f="${1##*/}" _pkgname + FWPKGTMP="$( tmpdir "${DESTDIR}/var/db/pkg/.firmware" )" + local flags=-VM + "$VERBOSE" && flags=-vm + ftp -N "${0##/}" -D "Install" "$flags" -o- "file:${1}" | + tar -s ",^\+,${FWPKGTMP}/+," \ -s ",^firmware,${DESTDIR}/etc/firmware," \ -C / -zxphf - "+*" "firmware/*" + _pkgname="$( sed -n '/^@name /{s///p;q;}' "${FWPKGTMP}/+CONTENTS" )" + if [ ! "$_pkgname" ]; then + echo "Failed to extract name from $1, partial install" 2>&1 + rm -rf "$FWPKGTMP" + unset FWPKGTMP + return 1 + fi + # TODO: Should we mark these so real fw_update can -Drepair? - ed -s "${_pkgdir}/+CONTENTS" <&2 + return 2 + fi + set -A _remove -- "${_cwd}/+CONTENTS" "${_cwd}" while read -r c g; do @@ -165,7 +260,9 @@ if [ -d "$_r" ]; then # Try hard not to actually remove recursively # without rmdir on the install media. + set +o noglob [ "$_r/*" = "$( echo "$_r"/* )" ] && rm -rf "$_r" + set -o noglob else rm -f "$_r" fi @@ -173,45 +270,137 @@ } usage() { - echo "usage: fw_install [-d dir | -L dir] [driver | file [...]]" + echo "usage: ${0##*/} [-d | -D] [-av] [-p path] [driver | file ...]" exit 2 } -INSTALL=true -DOWNLOAD=true - -while getopts dL name +ALL=false +OPT_D= +while getopts :adDnp:v name do case "$name" in - # "download only" means local dir and don't install - d) LOCALSRC=. INSTALL=false ;; - L) LOCALSRC=. ;; - ?) usage 2 ;; + a) ALL=true ;; + d) DELETE=true ;; + D) OPT_D=true ;; + n) DRYRUN=true ;; + p) LOCALSRC="$OPTARG" ;; + v) VERBOSE=true ;; + :) + echo "${0##*/}: option requires an argument -- -$OPTARG" >&2 + usage 2 + ;; + ?) + echo "${0##*/}: unknown option -- -$OPTARG" >&2 + usage 2 + ;; esac done shift $((OPTIND - 1)) -# If we're installing from a local dir -# we don't want to download anything -[ "$LOCALSRC" ] && "$INSTALL" && DOWNLOAD=false -[ "$LOCALSRC" ] || LOCALSRC="$( tmpdir "${DESTDIR}/tmp/fw_install" )" +if [ "$LOCALSRC" ]; then + if [[ $LOCALSRC = @(ftp|http?(s))://* ]]; then + FWURL="${LOCALSRC}" + LOCALSRC= + else + LOCALSRC="${LOCALSRC:#file:}" + ! [ -d "$LOCALSRC" ] && + echo "The path must be a URL or an existing directory" >&2 && + exit 2 + fi +fi -set -A devices -- "$@" +# "Download only" means local dir and don't install +if [ "$OPT_D" ]; then + INSTALL=false + LOCALSRC="${LOCALSRC:-.}" +elif [ "$LOCALSRC" ]; then + DOWNLOAD=false +fi -[ "${devices[*]:-}" ] || - set -A devices -- $( devices_needing_firmware ) +if [ -x /usr/bin/id ] && [ "$(/usr/bin/id -u)" != 0 ]; then + echo "need root privileges" >&2 + exit 1 +fi -if [ ! "${devices[*]:-}" ]; then - echo "No devices found which need firmware files to be downloaded." +set -sA devices -- "$@" + +if "$DELETE"; then + [ "$OPT_D" ] && usage 22 + + set -A installed + if [ "${devices[*]:-}" ]; then + "$ALL" && usage 22 + + set -A installed -- $( + for d in "${devices[@]}"; do + f="${d##*/}" # only care about the name + f="${f%.tgz}" # allow specifying the package name + [ "$( firmware_devicename "$f" )" = "$f" ] && f="$f-firmware" + + set -A i -- $( installed_firmware '' "$f-" '*' ) + + if [ "${i[*]:-}" ]; then + echo "${i[@]}" + else + echo "No firmware found for '$d'" >&2 + fi + done + ) + elif "$ALL"; then + set -A installed -- $( installed_firmware '*' '-firmware-' '*' ) + fi + + deleted='' + if [ "${installed:-}" ]; then + for fw in "${installed[@]}"; do + if "$DRYRUN"; then + "$VERBOSE" && echo "Delete $fw" + else + delete_firmware "$fw" || continue + fi + deleted="$deleted,$( firmware_devicename "$fw" )" + done + fi + + deleted="${deleted:+${deleted#,}}" + echo "${0:##*/}: deleted ${deleted:-none}"; + exit fi +if [ ! "$LOCALSRC" ]; then + LOCALSRC="$( tmpdir "${DESTDIR}/tmp/${0##*/}" )" + REMOVE_LOCALSRC=true +fi + +CFILE="$LOCALSRC/$CFILE" + +if [ "${devices[*]:-}" ]; then + "$ALL" && usage 22 +else + "$VERBOSE" && echo -n "Detecting firmware ..." + set -sA devices -- $( detect_firmware ) + "$VERBOSE" && + { [ "${devices[*]:-}" ] && echo " found." || echo " done." ; } +fi + +[ "${devices[*]:-}" ] || exit + if "$DOWNLOAD"; then + set +o noclobber # we want to get the latest CFILE fetch "$CFILE" + set -o noclobber ! signify -qVep "$FWPUB_KEY" -x "$CFILE" -m "$CFILE" && echo "Signature check of SHA256.sig failed" >&2 && exit 1 +elif [ ! -e "$CFILE" ]; then + # TODO: We shouldn't need a CFILE if all arguments are files. + echo "${0##*/}: $CFILE: No such file or directory" >&2 + exit 2 fi +added='' +updated='' +kept='' for f in "${devices[@]}"; do d="$( firmware_devicename "$f" )" @@ -219,17 +408,18 @@ f=$( firmware_filename "$d" || true ) [ "$f" ] || continue f="$LOCALSRC/$f" - elif ! "$INSTALL" && ! grep -q "($f)" "$CFILE" ; then + elif ! "$INSTALL" && ! grep -Fq "($f)" "$CFILE" ; then echo "Cannot download local file $f" >&2 exit 2 fi - set -A installed -- $( installed_firmware "$d" ) + set -A installed -- $( installed_firmware '' "$d-firmware-" '*' ) if "$INSTALL" && [ "${installed[*]:-}" ]; then for i in "${installed[@]}"; do if [ "${f##*/}" = "$i.tgz" ]; then - echo "$i already installed" + "$VERBOSE" && echo "Keep $i" + kept="$kept,$d" continue 2 fi done @@ -237,26 +427,53 @@ if [ -e "$f" ]; then if "$DOWNLOAD"; then - echo "Verify existing ${f##*/}" - verify "$f" || continue + "$VERBOSE" && ! "$INSTALL" && + echo "Keep/Verify ${f##*/}" + "$DRYRUN" || verify "$f" || continue + "$INSTALL" || kept="$kept,$d" # else assume it was verified when downloaded fi - elif "$INSTALL" && ! "$DOWNLOAD"; then + elif "$DOWNLOAD"; then + if "$DRYRUN"; then + "$VERBOSE" && echo "Get/Verify ${f##*/}" + else + fetch "$f" || continue + verify "$f" || continue + fi + "$INSTALL" || added="$added,$d" + elif "$INSTALL"; then echo "Cannot install ${f##*/}, not found" >&2 continue - else - fetch "$f" || continue - verify "$f" || continue fi "$INSTALL" || continue + removed=false if [ "${installed[*]:-}" ]; then for i in "${installed[@]}"; do - delete_firmware "$i" + "$DRYRUN" || delete_firmware "$i" + removed=true done fi - add_firmware "$f" + "$DRYRUN" || add_firmware "$f" + + f="${f##*/}" + f="${f%.tgz}" + if "$removed"; then + "$DRYRUN" && "$VERBOSE" && echo "Update $f" + updated="$updated,$d" + else + "$DRYRUN" && "$VERBOSE" && echo "Install $f" + added="$added,$d" + fi done +added="${added:#,}" +updated="${updated:#,}" +kept="${kept:#,}" +if "$INSTALL"; then + echo "${0##*/}: added ${added:-none}; updated ${updated:-none}; kept ${kept:-none}" +else + echo "${0##*/}: downloaded ${added:-none}; kept ${kept:-none}" +fi