=================================================================== RCS file: /cvs/openbsd/fw_update/fw_install.sh,v retrieving revision 1.43 retrieving revision 1.44 diff -u -r1.43 -r1.44 --- openbsd/fw_update/fw_install.sh 2021/12/02 02:56:37 1.43 +++ openbsd/fw_update/fw_install.sh 2021/12/02 03:05:49 1.44 @@ -1,5 +1,5 @@ #!/bin/ksh -# $OpenBSD: fw_install.sh,v 1.43 2021/12/02 02:56:37 afresh1 Exp $ +# $OpenBSD: fw_install.sh,v 1.44 2021/12/02 03:05:49 afresh1 Exp $ set -e # Copyright (c) 2021 Andrew Hewus Fresh @@ -23,14 +23,24 @@ # tmpdir, do_as, unpriv, and unpriv2 are from install.sub # modified to use su(1) when not in the installer. +# modified to use mktemp(1) when not in the installer. # Create a temporary directory based on the supplied directory name prefix. tmpdir() { local _i=1 _dir + if [[ -z $1 ]]; then + echo No tmpdir >&2 + exit 1 + fi - until _dir="${1?}.$_i.$RANDOM" && mkdir -- "$_dir" 2>/dev/null; do - ((++_i < 10000)) || return 1 - done + if [[ -e /usr/bin/mktemp ]]; then + _dir=$(/usr/bin/mktemp -d $1 ) + chown _sndio "$_dir" + else + until _dir="${1?}.$_i.$RANDOM" && mkdir -- "$_dir" 2>/dev/null; do + ((++_i < 10000)) || return 1 + done + fi echo "$_dir" } @@ -144,7 +154,7 @@ # Create a download directory for the firmware and # check that the _sndio user can read files from # it. Otherwise cleanup and skip the filesystem. - if _tmpsrc=$(tmpdir "$_tmpfs/firmware"); then + if _tmpsrc=$(tmpdir "$_tmpfs/firmware-XXXXXXXXX"); then ( >$_tmpsrc/t && $_unpriv cat $_tmpsrc/t