===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.22
retrieving revision 1.25
diff -u -r1.22 -r1.25
--- openbsd/fw_update/fw_install.sh	2021/11/11 02:05:56	1.22
+++ openbsd/fw_update/fw_install.sh	2021/11/11 02:38:32	1.25
@@ -6,8 +6,9 @@
 	sed -n "$1" /var/run/dmesg.boot
 }
 
+# Fake up some things from install.sub that we don't need to actually do
 prefetcharea_fs_list() {
-    echo "/mnt/tmp"
+	echo "/mnt/tmp"
 }
 reset_watchdog() {
 }
@@ -100,13 +101,13 @@
 
 # TODO: support srclocal installation of firmware somehow
 fw_update() {
-	local _src=$FWURL _tmpfs_list _tmpfs _tmpsrc
-    local _t=Get _cfile="/tmp/SHA256" _srclocal=false
-	local _f _r _remove _i _installed
-	local _pkgdir=/mnt/var/db/pkg
+	local _src=$1 _tmpfs_list _tmpfs _tmpsrc \
+		_t=Get _cfile="/tmp/SHA256" _pkgdir=/mnt/var/db/pkg \
+		_f _r _remove _i _installed
+	local _srclocal=false _unpriv=unpriv
 	local _d _drivers=$(
 		last=''
-		ftp -D "Detecting" -Vmo- $FWPATTERNS |
+		$_unpriv ftp -D "Detecting" -Vmo- $FWPATTERNS |
 		while read _d _m; do
 			grep=grep
 			[ "$last" = "$_d" ] && continue
@@ -158,7 +159,7 @@
 	    echo "Cannot fetch SHA256.sig" >&2 && return 1
 
 	# Verify signature file with public keys.
-	! unpriv -f "$_cfile" \
+	! $_unpriv -f "$_cfile" \
 	    signify -Vep $FWPUB_KEY -x "$_cfile.sig" -m "$_cfile" &&
 	    echo "Signature check of SHA256.sig failed" >&2 && return 1
 
@@ -174,7 +175,7 @@
 
 		for _i in $_installed; do
 			if [ "$_f" = "$_i.tgz" ]; then
-				echo "Firmware for $_d already installed ($_installed)"
+				echo "$_i already installed"
 				continue 2
 			fi
 		done
@@ -234,10 +235,11 @@
 		fi
 
 		# TODO: Should we mark these so real fw_update can -Drepair?
-		echo "Installing $_f"
-		tar -zxphf "$_tmpsrc/$_f" -C "/mnt/etc" "firmware/*"
-		mkdir -p ${_pkgdir}/${_f%.tgz}/
-		tar -zxphf "$_tmpsrc/$_f" -C "${_pkgdir}/${_f%.tgz}" "+*"
+		ftp -D "Install" -Vmo- "file:$_tmpsrc/$_f" |
+			tar -s ",^\+,${_pkgdir}/${_f%.tgz}/+," \
+			-s ",^firmware,mnt/etc/firmware," \
+			-C / -zxphf - "+*" "firmware/*"
+
 		ed -s "${_pkgdir}/${_f%.tgz}/+CONTENTS" <<EOL
 /^@comment pkgpath/ -1a
 @option manual-installation
@@ -249,4 +251,4 @@
 	done
 }
 
-fw_update
+fw_update "$FWURL"