===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.18
retrieving revision 1.24
diff -u -r1.18 -r1.24
--- openbsd/fw_update/fw_install.sh	2021/10/18 00:33:07	1.18
+++ openbsd/fw_update/fw_install.sh	2021/11/11 02:34:00	1.24
@@ -6,12 +6,12 @@
 	sed -n "$1" /var/run/dmesg.boot
 }
 
-installed_firmware() {
-	for fw in ${PKGDIR}/$1-firmware*; do
-		[ -e "$fw" ] || continue
-		echo ${fw##*/}
-	done
+# Fake up some things from install.sub that we don't need to actually do
+prefetcharea_fs_list() {
+    echo "/mnt/tmp"
 }
+reset_watchdog() {
+}
 
 # tmpdir, do_as, unpriv, and unpriv2 are from install.sub
 
@@ -70,6 +70,7 @@
 	do_as _file "$@"
 }
 
+# "fail" needs to be replaced with the "ask_yn" loop like in the installer.
 _issue=
 fail() {
 	echo $_issue >&2
@@ -96,15 +97,17 @@
 
 FWURL=http://firmware.openbsd.org/firmware/${HTTP_FWDIR}
 FWPUB_KEY=${DESTDIR}/etc/signify/openbsd-${VERSION}-fw.pub
-PKGDIR=${DESTDIR}/var/db/pkg
-PATTERNS="file:${0%/*}/firmware_patterns"
+FWPATTERNS="file:${0%/*}/firmware_patterns"
 
+# TODO: support srclocal installation of firmware somehow
 fw_update() {
-	local _tmpsrc _f _r _remove _i _installed
-	local _src=$FWURL _t=Get _cfile="/tmp/SHA256" _srclocal=false
+	local _src=$1 _tmpfs_list _tmpfs _tmpsrc \
+        _t=Get _cfile="/tmp/SHA256" _pkgdir=/mnt/var/db/pkg \
+        _f _r _remove _i _installed
+    local _srclocal=false _unpriv=unpriv
 	local _d _drivers=$(
 		last=''
-		ftp -D "Detecting" -Vmo- $PATTERNS |
+		$_unpriv ftp -D "Detecting" -Vmo- $FWPATTERNS |
 		while read _d _m; do
 			grep=grep
 			[ "$last" = "$_d" ] && continue
@@ -117,41 +120,62 @@
 	)
 
 	if [ -z "$_drivers" ]; then
-		echo "No devices found which need firmware files to be downloaded." >&2
+		echo "No devices found which need firmware files to be downloaded."
 		return
 	fi
 
-	if _tmpsrc=$( tmpdir "${DESTDIR}/tmp/fw_update" ); then
-		(
-		>$_tmpsrc/t &&
-		$_unpriv cat $_tmpsrc/t
-		) >/dev/null 2>&1 ||
-		    rm -r $_tmpsrc
-	fi
+	! _tmpfs_list=$(prefetcharea_fs_list) &&
+		echo "Cannot determine prefetch area" >&2 && return
 
+	for _tmpfs in $_tmpfs_list; do
+		# Try to clean up from previous runs, assuming
+		# the _tmpfs selection yields the same mount
+		# point.
+		for _tmpsrc in $_tmpfs/firmware.+([0-9]).+([0-9]); do
+			[[ -d $_tmpsrc ]] && rm -r $_tmpsrc
+		done
+
+		# Create a download directory for the firmware and
+		# check that the _sndio user can read files from
+		# it. Otherwise cleanup and skip the filesystem.
+		if _tmpsrc=$(tmpdir "$_tmpfs/firmware"); then
+			(
+			>$_tmpsrc/t &&
+			$_unpriv cat $_tmpsrc/t
+			) >/dev/null 2>&1 && break ||
+				rm -r $_tmpsrc
+		fi
+	done
+
 	[[ ! -d $_tmpsrc ]] &&
-		_issue="Cannot create prefetch area" && fail
+		echo "Cannot create prefetch area" >&2 && return 1
 
 	# Cleanup from previous runs.
 	rm -f $_cfile $_cfile.sig
 
-    _t=Get/Verify
+	_t=Get/Verify
 
 	! $_unpriv ftp -D "$_t" -Vmo - "$_src/SHA256.sig" >"$_cfile.sig" &&
-	    _issue="Cannot fetch SHA256.sig" && fail
+	    echo "Cannot fetch SHA256.sig" >&2 && return 1
 
 	# Verify signature file with public keys.
-	! unpriv -f "$_cfile" \
+	! $_unpriv -f "$_cfile" \
 	    signify -Vep $FWPUB_KEY -x "$_cfile.sig" -m "$_cfile" &&
-	    _issue="Signature check of SHA256.sig failed" && fail
+	    echo "Signature check of SHA256.sig failed" >&2 && return 1
 
 	for _d in $_drivers; do
+		$UU && reset_watchdog
 		_f=$( sed -n "s/.*(\($_d-firmware-.*\.tgz\)).*/\1/p" "$_cfile" )
-		_installed=$( installed_firmware "$_d" )
+		_installed=$(
+	        for fw in "${_pkgdir}/$_d-firmware"*; do
+		        [ -e "$fw" ] || continue
+		        echo ${fw##*/}
+	        done
+		)
 
 		for _i in $_installed; do
 			if [ "$_f" = "$_i.tgz" ]; then
-				echo "Firmware for $_d already installed ($_installed)"
+				echo "$_i already installed"
 				continue 2
 			fi
 		done
@@ -168,38 +192,37 @@
 		# Handle failed transfer.
 		if [[ -f /tmp/fail ]]; then
 			rm -f "$_tmpsrc/$_f"
-			_issue="Fetching of $_f failed!"
-			fail
+			echo "Fetching of $_f failed!" >&2
+			continue
 		fi
 
 		# Verify firmware by comparing its checksum with SHA256.
-		if fgrep -qx "SHA256 ($_f) = $(</tmp/h)" "$_cfile"; then
-			#_unver=$(rmel $_f $_unver)
-			true
-		else
+		if ! fgrep -qx "SHA256 ($_f) = $(</tmp/h)" "$_cfile"; then
 			[[ -d "$_tmpsrc" ]] && rm -rf "$_tmpsrc"
-			_issue="Checksum test for $_f failed."
-			fail
+			echo "Checksum test for $_f failed." >&2
+			continue
 		fi
 
 		# TODO: Check hash for files before deleting
-		if [ "$_installed" ] && [ -e "${PKGDIR}/$_installed/+CONTENTS" ]; then
+		if [ "$_installed" ] && [ -e "${_pkgdir}/$_installed/+CONTENTS" ]; then
 			echo "Uninstalling $_installed"
-			cwd=${PKGDIR}/$_installed
+			cwd=${_pkgdir}/$_installed
 
 			set -A _remove -- "${cwd}/+CONTENTS" "${cwd}"
 
 			while read c g; do
 				case $c in
-				@cwd) cwd="${DESTDIR}/$g"
+				@cwd) cwd="/mnt/$g"
 				  ;;
 				@*) continue
 				  ;;
 				*)  set -A _remove -- "$cwd/$c" "${_remove[@]}"
 				  ;;
 				esac
-			done < "${PKGDIR}/$_installed/+CONTENTS"
+			done < "${_pkgdir}/$_installed/+CONTENTS"
 
+			# We specifically rm -f here because not removing files/dirs
+			# is probably not worth failing over.
 			for _r in "${_remove[@]}" ; do
 				if [ -d "$_r" ]; then
 					# Try hard not to actually remove recursively
@@ -211,13 +234,14 @@
 			done
 		fi
 
-        # TODO: Add some details about the install to +CONTENTS like pkg_add
-        # TODO: Or, maybe we save the firmware someplace and make pkg_add reinstall
-		echo "Installing $_f"
-		tar -zxphf "$_tmpsrc/$_f" -C "${DESTDIR}/etc" "firmware/*"
-		mkdir -p ${PKGDIR}/${_f%.tgz}/
-		tar -zxphf "$_tmpsrc/$_f" -C "${PKGDIR}/${_f%.tgz}" "+*"
-		ed -s "${PKGDIR}/${_f%.tgz}/+CONTENTS" <<EOL
+		# TODO: Should we mark these so real fw_update can -Drepair?
+		$_unpriv ftp -D "Install" -Vmo- "file:$_tmpsrc/$_f" |
+            tar -s ",^\+,${_pkgdir}/${_f%.tgz}/+," \
+                -s ",^firmware,mnt/etc/firmware," \
+                -C / -zxphf - \
+                "+*" "firmware/*"
+
+		ed -s "${_pkgdir}/${_f%.tgz}/+CONTENTS" <<EOL
 /^@comment pkgpath/ -1a
 @option manual-installation
 @option firmware
@@ -228,4 +252,4 @@
 	done
 }
 
-fw_update
+fw_update "$FWURL"