===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.122
retrieving revision 1.136
diff -u -r1.122 -r1.136
--- openbsd/fw_update/fw_install.sh	2021/12/24 02:36:13	1.122
+++ openbsd/fw_update/fw_install.sh	2021/12/25 20:48:40	1.136
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.122 2021/12/24 02:36:13 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.136 2021/12/25 20:48:40 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -34,12 +34,24 @@
 FWURL=http://firmware.openbsd.org/firmware/${HTTP_FWDIR}
 FWPUB_KEY=${DESTDIR}/etc/signify/openbsd-${VERSION}-fw.pub
 
+DRYRUN=false
 VERBOSE=false
 DELETE=false
 DOWNLOAD=true
 INSTALL=true
 LOCALSRC=
 
+unset FTPPID
+unset FWPKGTMP
+REMOVE_LOCALSRC=false
+cleanup() {
+	set +o errexit # ignore errors from killing ftp
+	[ "${FTPPID:-}" ] && kill -TERM -"$FTPPID" 2>/dev/null
+	[ "${FWPKGTMP:-}" ] && rm -rf "$FWPKGTMP"
+	"$REMOVE_LOCALSRC" && rm -rf "$LOCALSRC"
+}
+trap cleanup EXIT
+
 tmpdir() {
 	local _i=1 _dir
 
@@ -57,7 +69,7 @@
 }
 
 fetch() {
-	local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _pid _exit _error=''
+	local _src="${FWURL}/${1##*/}" _dst=$1 _user=_file _exit _error=''
 
 	# If we're not in the installer,
 	# we have su(1) and doas(1) is unlikely to be configured.
@@ -72,14 +84,12 @@
 		exec /usr/bin/doas -u "$_user" \
 		    /usr/bin/ftp -N "${0##/}" -D 'Get/Verify' $flags -o- "$_src" > "$_dst"
 	fi
-	) & _pid=$!
+	) & FTPPID=$!
 	set +o monitor
 
-	trap "kill -TERM '-$_pid' 2>/dev/null; exit 1" EXIT INT QUIT ABRT TERM
-
 	SECONDS=0
 	_last=0
-	while kill -0 -"$_pid" 2>/dev/null; do
+	while kill -0 -"$FTPPID" 2>/dev/null; do
 		if [[ $SECONDS -gt 12 ]]; then
 			set -- $( ls -ln "$_dst" 2>/dev/null )
 			if [[ $_last -ne $5 ]]; then
@@ -87,7 +97,7 @@
 				SECONDS=0
 				sleep 1
 			else
-				kill -INT -"$_pid"
+				kill -INT -"$FTPPID"
 				_error=" (timed out)"
 			fi
 		else
@@ -96,11 +106,11 @@
 	done
 
 	set +o errexit
-	wait "$_pid"
+	wait "$FTPPID"
 	_exit=$?
 	set -o errexit
 
-	trap "" EXIT INT QUIT ABRT TERM
+	unset FTPPID
 
 	if [ "$_exit" -ne 0 ]; then
 		rm -f "$_dst"
@@ -117,13 +127,12 @@
 	fi
 }
 
-devices_needing_firmware() {
+firmware_in_dmesg() {
 	local _d _m _line _dmesgtail _last='' _nl=$( echo )
 
 	# When we're not in the installer, the dmesg.boot can
 	# contain multiple boots, so only look in the last one
-	_dmesgtail="$( echo ; sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot |
-	    grep -e "^[a-z][a-z]*[0-9]" -e " not configured " )"
+	_dmesgtail="$( echo ; sed -n 'H;/^OpenBSD/h;${g;p;}' /var/run/dmesg.boot )"
 
 	grep -v '^[[:space:]]*#' "$FWPATTERNS" |
 	    while read -r _d _m; do
@@ -153,7 +162,7 @@
 
 installed_firmware() {
 	local _pre="$1" _match="$2" _post="$3" _firmware
-	set -A _firmware -- $(
+	set -sA _firmware -- $(
 	    set +o noglob
 	    grep -Fxl '@option firmware' \
 		"${DESTDIR}/var/db/pkg/"$_pre"$_match"$_post"/+CONTENTS" \
@@ -168,25 +177,44 @@
 	done
 }
 
+detect_firmware() {
+	local _devices _last='' _d
+
+	set -sA _devices -- $(
+	    firmware_in_dmesg
+	    for _d in $( installed_firmware '*' '-firmware-' '*' ); do
+		firmware_devicename "$_d"
+	    done
+	)
+
+	[ "${_devices[*]:-}" ] || return 0
+	for _d in "${_devices[@]}"; do
+		[ "$_last" = "$_d" ] && continue
+		echo "$_d"
+		_last="$_d"
+	done
+}
+
 add_firmware () {
 	local _f="${1##*/}" _pkgname
-	local _tmpdir="$( tmpdir "${DESTDIR}/var/db/pkg/.firmware" )"
+	FWPKGTMP="$( tmpdir "${DESTDIR}/var/db/pkg/.firmware" )"
 	local flags=-VM
 	"$VERBOSE" && flags=-vm
 	ftp -N "${0##/}" -D "Install" "$flags" -o- "file:${1}" |
-		tar -s ",^\+,${_tmpdir}/+," \
+		tar -s ",^\+,${FWPKGTMP}/+," \
 		    -s ",^firmware,${DESTDIR}/etc/firmware," \
 		    -C / -zxphf - "+*" "firmware/*"
 
-	_pkgname="$( sed -n '/^@name /{s///p;q;}' "${_tmpdir}/+CONTENTS" )"
+	_pkgname="$( sed -n '/^@name /{s///p;q;}' "${FWPKGTMP}/+CONTENTS" )"
 	if [ ! "$_pkgname" ]; then
 		echo "Failed to extract name from $1, partial install" 2>&1
-		rm -rf "$_tmpdir"
+		rm -rf "$FWPKGTMP"
+		unset FWPKGTMP
 		return 1
 	fi
 
 	# TODO: Should we mark these so real fw_update can -Drepair?
-	ed -s "${_tmpdir}/+CONTENTS" <<EOL
+	ed -s "${FWPKGTMP}/+CONTENTS" <<EOL
 /^@comment pkgpath/ -1a
 @option manual-installation
 @option firmware
@@ -195,8 +223,9 @@
 w
 EOL
 
-	chmod 755 "$_tmpdir"
-	mv "$_tmpdir" "${DESTDIR}/var/db/pkg/${_pkgname}"
+	chmod 755 "$FWPKGTMP"
+	mv "$FWPKGTMP" "${DESTDIR}/var/db/pkg/${_pkgname}"
+	unset FWPKGTMP
 }
 
 delete_firmware() {
@@ -247,12 +276,13 @@
 
 ALL=false
 OPT_D=
-while getopts :adDp:v name
+while getopts :adDnp:v name
 do
        case "$name" in
        a) ALL=true ;;
        d) DELETE=true ;;
        D) OPT_D=true ;;
+       n) DRYRUN=true ;;
        p) LOCALSRC="$OPTARG" ;;
        v) VERBOSE=true ;;
        :)
@@ -283,18 +313,16 @@
 if [ "$OPT_D" ]; then
 	INSTALL=false
 	LOCALSRC="${LOCALSRC:-.}"
+elif [ "$LOCALSRC" ]; then
+	DOWNLOAD=false
 fi
 
-[ "$LOCALSRC" ] || LOCALSRC="$( tmpdir "${DESTDIR}/tmp/${0##*/}" )"
-
-CFILE="$LOCALSRC/$CFILE"
-
 if [ -x /usr/bin/id ] && [ "$(/usr/bin/id -u)" != 0 ]; then
 	echo "need root privileges" >&2
 	exit 1
 fi
 
-set -A devices -- "$@"
+set -sA devices -- "$@"
 
 if "$DELETE"; then
 	[ "$OPT_D" ] && usage 22
@@ -325,7 +353,11 @@
 	deleted=''
 	if [ "${installed:-}" ]; then
 		for fw in "${installed[@]}"; do
-			delete_firmware "$fw" || continue
+			if "$DRYRUN"; then
+				"$VERBOSE" && echo "Delete $fw"
+			else
+				delete_firmware "$fw" || continue
+			fi
 			deleted="$deleted,$( firmware_devicename "$fw" )"
 		done
 	fi
@@ -336,11 +368,18 @@
 	exit
 fi
 
+if [ ! "$LOCALSRC" ]; then
+    LOCALSRC="$( tmpdir "${DESTDIR}/tmp/${0##*/}" )"
+    REMOVE_LOCALSRC=true
+fi
+
+CFILE="$LOCALSRC/$CFILE"
+
 if [ "${devices[*]:-}" ]; then
 	"$ALL" && usage 22
 else
 	"$VERBOSE" && echo -n "Detecting firmware ..."
-	set -A devices -- $( devices_needing_firmware )
+	set -sA devices -- $( detect_firmware )
 	"$VERBOSE" &&
 	    { [ "${devices[*]:-}" ] && echo " found." || echo " done." ; }
 fi
@@ -379,7 +418,7 @@
 	if "$INSTALL" && [ "${installed[*]:-}" ]; then
 		for i in "${installed[@]}"; do
 			if [ "${f##*/}" = "$i.tgz" ]; then
-				"$VERBOSE" && echo "$i already installed"
+				"$VERBOSE" && echo "Keep $i"
 				kept="$kept,$d"
 				continue 2
 			fi
@@ -388,14 +427,19 @@
 
 	if [ -e "$f" ]; then
 		if "$DOWNLOAD"; then
-			"$VERBOSE" && echo "Verify existing ${f##*/}"
-			verify "$f" || continue
-			"$INSTALL"  || kept="$kept,$d"
+			"$VERBOSE" && ! "$INSTALL" &&
+			    echo "Keep/Verify ${f##*/}"
+			"$DRYRUN"  || verify "$f" || continue
+			"$INSTALL" || kept="$kept,$d"
 		# else assume it was verified when downloaded
 		fi
 	elif "$DOWNLOAD"; then
-		fetch  "$f" || continue
-		verify "$f" || continue
+		if "$DRYRUN"; then
+			"$VERBOSE" && echo "Get/Verify ${f##*/}"
+		else
+			fetch  "$f" || continue
+			verify "$f" || continue
+		fi
 		"$INSTALL"  || added="$added,$d"
 	elif "$INSTALL"; then
 		echo "Cannot install ${f##*/}, not found" >&2
@@ -407,16 +451,20 @@
 	removed=false
 	if [ "${installed[*]:-}" ]; then
 		for i in "${installed[@]}"; do
-			delete_firmware "$i"
+			"$DRYRUN" || delete_firmware "$i"
 			removed=true
 		done
 	fi
 
-	add_firmware "$f"
+	"$DRYRUN" || add_firmware "$f"
 
+	f="${f##*/}"
+	f="${f%.tgz}"
 	if "$removed"; then
+		"$DRYRUN" && "$VERBOSE" && echo "Update $f"
 		updated="$updated,$d"
 	else
+		"$DRYRUN" && "$VERBOSE" && echo "Install $f"
 		added="$added,$d"
 	fi
 done