===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.118
retrieving revision 1.123
diff -u -r1.118 -r1.123
--- openbsd/fw_update/fw_install.sh	2021/12/24 00:46:02	1.118
+++ openbsd/fw_update/fw_install.sh	2021/12/24 17:57:54	1.123
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.118 2021/12/24 00:46:02 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.123 2021/12/24 17:57:54 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -67,10 +67,10 @@
 	"$VERBOSE" && flags=-vm
 	if [ -x /usr/bin/su ]; then
 		exec /usr/bin/su -s /bin/ksh "$_user" -c \
-		    "/usr/bin/ftp -D 'Get/Verify' $flags -o- '$_src'" > "$_dst"
+		    "/usr/bin/ftp -N '${0##/}' -D 'Get/Verify' $flags -o- '$_src'" > "$_dst"
 	else
 		exec /usr/bin/doas -u "$_user" \
-		    /usr/bin/ftp -D 'Get/Verify' $flags -o- "$_src" > "$_dst"
+		    /usr/bin/ftp -N "${0##/}" -D 'Get/Verify' $flags -o- "$_src" > "$_dst"
 	fi
 	) & _pid=$!
 	set +o monitor
@@ -153,7 +153,7 @@
 
 installed_firmware() {
 	local _pre="$1" _match="$2" _post="$3" _firmware
-	set -A _firmware -- $(
+	set -sA _firmware -- $(
 	    set +o noglob
 	    grep -Fxl '@option firmware' \
 		"${DESTDIR}/var/db/pkg/"$_pre"$_match"$_post"/+CONTENTS" \
@@ -173,7 +173,7 @@
 	local _tmpdir="$( tmpdir "${DESTDIR}/var/db/pkg/.firmware" )"
 	local flags=-VM
 	"$VERBOSE" && flags=-vm
-	ftp -D "Install" "$flags" -o- "file:${1}" |
+	ftp -N "${0##/}" -D "Install" "$flags" -o- "file:${1}" |
 		tar -s ",^\+,${_tmpdir}/+," \
 		    -s ",^firmware,${DESTDIR}/etc/firmware," \
 		    -C / -zxphf - "+*" "firmware/*"
@@ -241,40 +241,52 @@
 }
 
 usage() {
-	echo "usage:  ${0##*/} [-d | -D | -L] [-av] [driver | file ...]"
+	echo "usage:  ${0##*/} [-d | -D] [-av] [-p path] [driver | file ...]"
 	exit 2
 }
 
 ALL=false
 OPT_D=
-OPT_L=
-while getopts :adDLv name
+while getopts :adDp:v name
 do
        case "$name" in
        a) ALL=true ;;
        d) DELETE=true ;;
        D) OPT_D=true ;;
-       L) OPT_L=true ;;
+       p) LOCALSRC="$OPTARG" ;;
        v) VERBOSE=true ;;
-       ?) echo "${0##*/}: unknown option -- -$OPTARG"; usage 2 ;;
+       :)
+	   echo "${0##*/}: option requires an argument -- -$OPTARG" >&2
+	   usage 2
+	   ;;
+       ?)
+	   echo "${0##*/}: unknown option -- -$OPTARG" >&2
+	   usage 2
+	   ;;
        esac
 done
 shift $((OPTIND - 1))
 
-[ "$OPT_D" ] && [ "$OPT_L" ] && usage 1
+if [ "$LOCALSRC" ]; then
+	if [[ $LOCALSRC = @(ftp|http?(s))://* ]]; then
+		FWURL="${LOCALSRC}"
+		LOCALSRC=
+	else
+		LOCALSRC="${LOCALSRC:#file:}"
+		! [ -d "$LOCALSRC" ] &&
+		    echo "The path must be a URL or an existing directory" >&2 &&
+		    exit 2
+	fi
+fi
 
+# "Download only" means local dir and don't install
 if [ "$OPT_D" ]; then
-	# "Download only" means local dir and don't install
 	INSTALL=false
-	LOCALSRC=.
-elif [ "$OPT_L" ]; then
-	# "Local" means don't download, install from local dir
-	DOWNLOAD=false
-	LOCALSRC=.
-else
-	LOCALSRC="$( tmpdir "${DESTDIR}/tmp/${0##*/}" )"
+	LOCALSRC="${LOCALSRC:-.}"
 fi
 
+[ "$LOCALSRC" ] || LOCALSRC="$( tmpdir "${DESTDIR}/tmp/${0##*/}" )"
+
 CFILE="$LOCALSRC/$CFILE"
 
 if [ -x /usr/bin/id ] && [ "$(/usr/bin/id -u)" != 0 ]; then
@@ -282,10 +294,10 @@
 	exit 1
 fi
 
-set -A devices -- "$@"
+set -sA devices -- "$@"
 
 if "$DELETE"; then
-	[ "$OPT_D" ] || [ "$OPT_L" ] && usage 22
+	[ "$OPT_D" ] && usage 22
 
 	set -A installed
 	if [ "${devices[*]:-}" ]; then
@@ -328,7 +340,7 @@
 	"$ALL" && usage 22
 else
 	"$VERBOSE" && echo -n "Detecting firmware ..."
-	set -A devices -- $( devices_needing_firmware )
+	set -sA devices -- $( devices_needing_firmware )
 	"$VERBOSE" &&
 	    { [ "${devices[*]:-}" ] && echo " found." || echo " done." ; }
 fi
@@ -341,6 +353,10 @@
 	set -o noclobber
 	! signify -qVep "$FWPUB_KEY" -x "$CFILE" -m "$CFILE" &&
 	    echo "Signature check of SHA256.sig failed" >&2 && exit 1
+elif [ ! -e "$CFILE" ]; then
+	# TODO: We shouldn't need a CFILE if all arguments are files.
+	echo "${0##*/}: $CFILE: No such file or directory" >&2
+	exit 2
 fi
 
 added=''