===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.102
retrieving revision 1.107
diff -u -r1.102 -r1.107
--- openbsd/fw_update/fw_install.sh	2021/12/22 04:43:41	1.102
+++ openbsd/fw_update/fw_install.sh	2021/12/23 02:16:03	1.107
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.102 2021/12/22 04:43:41 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.107 2021/12/23 02:16:03 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -160,17 +160,24 @@
 }
 
 add_firmware () {
-	local _f="${1##*/}"
-	local _pkgdir="${DESTDIR}/var/db/pkg/${_f%.tgz}"
+	local _f="${1##*/}" _pkgname
+	local _tmpdir="$( tmpdir "${DESTDIR}/var/db/pkg/.firmware" )"
 	local flags=-VM
 	"$VERBOSE" && flags=-vm
 	ftp -D "Install" "$flags" -o- "file:${1}" |
-		tar -s ",^\+,${_pkgdir}/+," \
+		tar -s ",^\+,${_tmpdir}/+," \
 		    -s ",^firmware,${DESTDIR}/etc/firmware," \
 		    -C / -zxphf - "+*" "firmware/*"
 
+	_pkgname="$( sed -n '/^@name /{s///p;q;}' "${_tmpdir}/+CONTENTS" )"
+	if [ ! "$_pkgname" ]; then
+		echo "Failed to extract name from $1, partial install" 2>&1
+		rm -rf "$_tmpdir"
+		return 1
+	fi
+
 	# TODO: Should we mark these so real fw_update can -Drepair?
-	ed -s "${_pkgdir}/+CONTENTS" <<EOL
+	ed -s "${_tmpdir}/+CONTENTS" <<EOL
 /^@comment pkgpath/ -1a
 @option manual-installation
 @option firmware
@@ -178,6 +185,9 @@
 .
 w
 EOL
+
+	chmod 755 "$_tmpdir"
+	mv "$_tmpdir" "${DESTDIR}/var/db/pkg/${_pkgname}"
 }
 
 delete_firmware() {
@@ -187,6 +197,12 @@
 	"$VERBOSE" && echo "Uninstalling $_pkg"
 	_cwd="${_pkgdir}/$_pkg"
 
+	if [ ! -e "$_cwd/+CONTENTS" ] ||
+	    ! grep -Fxq '@option firmware' "$_cwd/+CONTENTS"; then
+		echo "${0##*/}: $_pkg does not appear to be firmware" >&2
+		return 2
+	fi
+
 	set -A _remove -- "${_cwd}/+CONTENTS" "${_cwd}"
 
 	while read -r c g; do
@@ -216,7 +232,7 @@
 }
 
 usage() {
-	echo "usage:  ${0##*/} [-D | -L] [driver | file ...]"
+	echo "usage:  ${0##*/} [-v] [-D | -L] [driver | file ...]"
 	exit 2
 }
 
@@ -249,7 +265,7 @@
 
 CFILE="$LOCALSRC/$CFILE"
 
-if "$INSTALL" && [ -x /usr/bin/id ] && [ $(/usr/bin/id -u) != 0 ]; then
+if "$INSTALL" && [ -x /usr/bin/id ] && [ "$(/usr/bin/id -u)" != 0 ]; then
 	echo "need root privileges" >&2
 	exit 1
 fi
@@ -271,6 +287,8 @@
 	    echo "Signature check of SHA256.sig failed" >&2 && exit 1
 fi
 
+added=''
+updated=''
 for f in "${devices[@]}"; do
 	d="$( firmware_devicename "$f" )"
 
@@ -310,12 +328,29 @@
 
 	"$INSTALL" || continue
 
+	removed=false
 	if [ "${installed[*]:-}" ]; then
 		for i in "${installed[@]}"; do
 			delete_firmware "$i"
+			removed=true
 		done
 	fi
 
 	add_firmware "$f"
+
+	if "$removed"; then
+		[ "$updated" ] && updated="$updated,"
+		updated="$updated$d"
+	else
+		[ "$added" ] && added="$added,"
+		added="$added$d"
+	fi
 done
 
+if ! $VERBOSE && { [ "$added" ] || [ "$updated" ]; }; then
+	echo  "${0##*/}: $(
+	    [ "$added" ] && echo -n "added ${added}"
+	    [ "$added" ] && [ "$updated" ] && echo -n "; "
+	    [ "$updated" ] && echo -n "updated ${updated}"
+	)"
+fi