===================================================================
RCS file: /cvs/openbsd/fw_update/fw_install.sh,v
retrieving revision 1.64
retrieving revision 1.68
diff -u -r1.64 -r1.68
--- openbsd/fw_update/fw_install.sh	2021/12/09 02:37:38	1.64
+++ openbsd/fw_update/fw_install.sh	2021/12/11 03:56:35	1.68
@@ -1,5 +1,5 @@
 #!/bin/ksh
-#	$OpenBSD: fw_install.sh,v 1.64 2021/12/09 02:37:38 afresh1 Exp $
+#	$OpenBSD: fw_install.sh,v 1.68 2021/12/11 03:56:35 afresh1 Exp $
 #
 # Copyright (c) 2021 Andrew Hewus Fresh <afresh1@openbsd.org>
 #
@@ -182,33 +182,35 @@
 }
 
 usage() {
-	echo "Usage: fw_install [ -d dir | -L dir ] [ driver | file [ ... ] ]"
+	echo "usage: fw_install [-d dir | -L dir] [driver | file [...]]"
 	exit 2
 }
 
-DOWNLOADDIR=
-LOCALDIR=
-while getopts d:L: name
+INSTALL=true
+DOWNLOAD=true
+LOCALDIR=false
+
+while getopts dL name
 do
        case "$name" in
-       d) DOWNLOADDIR=$OPTARG ;;
-       L) LOCALDIR=$OPTARG    ;;
+       # "download only" means local dir and don't install
+       d) LOCALDIR=true INSTALL=false ;;
+       L) LOCALDIR=true ;;
        ?) usage 2 ;;
        esac
 done
 shift $((OPTIND - 1))
 
-if [[ -n "${DOWNLOADDIR:-}" && -n "${LOCALDIR:-}" ]]; then
-	echo "Cannot use -d and -L" >&2
-	usage 2
-fi
+# If we're installing from a local dir
+# we don't want to download anything
+"$LOCALDIR" && "$INSTALL" && DOWNLOAD=false
 
 set -A devices -- "$@"
 
 [ "${devices[*]:-}" ] ||
     set -A devices -- $( devices_needing_firmware )
 
-if [ ! "${devices:-}" ]; then
+if [ ! "${devices[*]:-}" ]; then
 	echo "No devices found which need firmware files to be downloaded."
 	exit
 fi
@@ -219,9 +221,8 @@
 while (( i < "${#devices[@]}" )); do
 	f="${devices[$i]}"
 	d=$( firmware_devicename "$f" )
-	[ "$f" = "$d" ] && f="$( echo "$f"-firmware-*.tgz | sed '$!d' )"
 	if [ -e "$f" ]; then
-		if [ "${DOWNLOADDIR:-}" ]; then
+		if "$DOWNLOAD"; then
 			echo "Cannot download local file $f" >&2
 			exit 2
 		fi
@@ -230,22 +231,11 @@
 	i=$((i + 1))
 done
 
-if [ "$DOWNLOADDIR" ]; then
-	if ! cd "$DOWNLOADDIR"; then
-		echo "Unable to use $DOWNLOADDIR, make sure it is a directory"
-		exit 2
-	fi
-elif [ "$LOCALDIR" ]; then
-	if ! cd "$LOCALDIR"; then
-		echo "Unable to use $LOCALDIR, make sure it is a directory"
-		exit 2
-	fi
-else
-	TMPDIR=$( tmpdir "${DESTDIR}/tmp/fw_install" )
-	cd "$TMPDIR"
+if ! "$LOCALDIR"; then
+	cd "$( tmpdir "${DESTDIR}/tmp/fw_install" )"
 fi
 
-if ! [[ -n "$LOCALDIR" && -e "$CFILE" ]]; then
+if "$DOWNLOAD" && ! [[ -e "$CFILE" ]]; then
 	fetch "$CFILE"
 	! signify -qVep "$FWPUB_KEY" -x "$CFILE" -m "$CFILE" &&
 	    echo "Signature check of SHA256.sig failed" >&2 && exit 1
@@ -262,8 +252,8 @@
 
 	set -A installed -- $( installed_firmware "$d" )
 
-	if [ ! "${DOWNLOADDIR:-}" ] && [ "${installed:-}" ]; then
-		for i in "${installed[@]:-}"; do
+	if "$INSTALL" && [ "${installed[*]:-}" ]; then
+		for i in "${installed[@]}"; do
 			if [ "${f##*/}" = "$i.tgz" ]; then
 				echo "$i already installed"
 				continue 2
@@ -272,17 +262,18 @@
 	fi
 
 	if [ ! -e "$f" ]; then
-		[ "$LOCALDIR" ] && echo "Cannot install $f, not found" >&2 && continue
+		"$INSTALL" && ! "$DOWNLOAD" &&
+		    echo "Cannot install $f, not found" >&2 && continue
 		fetch  "$f" || continue
 		verify "$f" || continue
-	elif [ "${DOWNLOADDIR:-}" ]; then
+	elif $DOWNLOAD; then
 		echo "Already have $f"
 		verify "$f" || continue
 	fi
 
-	[ "${DOWNLOADDIR:-}" ] && continue
+	"$INSTALL" || continue
 
-	if [ "${installed:-}" ]; then
+	if [ "${installed[*]:-}" ]; then
 		for i in "${installed[@]}"; do
 			delete_firmware "$i"
 		done