=================================================================== RCS file: /cvs/RT/Invoicing/rt_invoices.pl,v retrieving revision 1.50 retrieving revision 1.51 diff -u -r1.50 -r1.51 --- RT/Invoicing/rt_invoices.pl 2013/06/20 05:36:06 1.50 +++ RT/Invoicing/rt_invoices.pl 2015/05/07 06:21:49 1.51 @@ -1,5 +1,5 @@ #!/usr/bin/perl -# $AFresh1: rt_invoices.pl,v 1.49 2013/02/05 03:41:58 andrew Exp $ +# $AFresh1: rt_invoices.pl,v 1.50 2013/06/20 04:36:06 andrew Exp $ ######################################################################## # Copyright (c) 2011 Andrew Fresh # @@ -422,7 +422,7 @@ while ( $date < $billend ) { my $start = $date->clone; - $date->add($freq); + $date->add_duration($freq); my $end = $date > $billend ? $billend->clone : $date->clone; $end->subtract( seconds => 1 ); @@ -637,7 +637,9 @@ } } - return $newest_invoice->clone->subtract($max_duration) + $newest_invoice ||= DateTime->now; + + return $newest_invoice->clone->subtract_duration($max_duration) ->subtract( days => 1 ); } @@ -650,7 +652,7 @@ my $end = DateTime->now( time_zone => 'local' ) ->set( hour => 0, minute => 0, second => 0 ); - my $start = $end->clone->subtract($freq); + my $start = $end->clone->subtract_duration($freq); # XXX This is helpful, but monthly and billday > 28 == !!! $end->subtract( days => 1 ) while $day && $end->$day_method != $day; @@ -666,7 +668,7 @@ ? DateTime->now->subtract( days => $cust->{net} ) : 0; - $cust->{no_invoice} = 1 if $start->clone->add($freq) > $end; + $cust->{no_invoice} = 1 if $start->clone->add_duration($freq) > $end; $cust->{billend} = $end; $cust->{billstart} = $start; }