=================================================================== RCS file: /cvs/HOPE/Net-OpenAMD/lib/Net/OpenAMD.pm,v retrieving revision 1.12 retrieving revision 1.20 diff -u -r1.12 -r1.20 --- HOPE/Net-OpenAMD/lib/Net/OpenAMD.pm 2010/06/28 21:32:32 1.12 +++ HOPE/Net-OpenAMD/lib/Net/OpenAMD.pm 2010/07/17 12:48:28 1.20 @@ -1,25 +1,29 @@ package Net::OpenAMD; -# $AFresh1: OpenAMD.pm,v 1.11 2010/06/28 17:49:31 andrew Exp $ +# $AFresh1: OpenAMD.pm,v 1.19 2010/07/14 05:21:23 andrew Exp $ -use version; our $VERSION = qv('0.0.1'); -my $BASE_URI = 'https://api.hope.net/api/'; - use warnings; use strict; use Carp; +use version; our $VERSION = qv('0.1.1'); +my $BASE_URI = 'https://api.hope.net/api/'; + use Scalar::Util qw( refaddr ); *_ident = \&refaddr; use LWP::UserAgent; use URI; use Net::OAuth; -use JSON::Any; +use JSON; { - my @attr_refs = \( my %base_uri_of, my %ua_of, my %auth_of, ); + my @attr_refs = \( + my %base_uri_of, + my %ua_of, my %auth_of, my %actions_of, + my %json_of, + ); sub new { my ( $class, $options ) = @_; @@ -32,7 +36,16 @@ $base_uri_of{$ident} = $options->{base_uri} || $BASE_URI; $ua_of{$ident} = $options->{ua} || LWP::UserAgent->new(); + $json_of{$ident} = $options->{json} || JSON->new(); + $actions_of{$ident} = $options->{actions} + || [qw( location speakers talks interests users )]; + foreach my $action ( @{ $actions_of{$ident} } ) { + ## no critic + no strict 'refs'; + *{$action} = sub { shift->get( $action, @_ ) }; + } + # XXX Authenticate return $self; @@ -42,21 +55,22 @@ my ( $self, $action, $query ) = @_; my $ident = _ident($self); - my $uri = URI->new_abs( $action, $base_uri_of{$ident} ); - $uri->query($query); + my $uri = URI->new_abs( $action . '/', $base_uri_of{$ident} ); + $uri->query_form($query); my $response = $ua_of{$ident}->get($uri); croak $response->status_line if !$response->is_success; - return JSON::Any->jsonToObj( $response->decoded_content ); + my $data; + eval { + $data = $json_of{$ident}->decode( $response->decoded_content ); + }; + croak "Invalid JSON from [$uri]" if $@; + + return $data; } - sub location { return shift->get( 'location', @_ ) } - sub speakers { return shift->get( 'speakers', @_ ) } - sub talks { return shift->get( 'talks', @_ ) } - sub interests { return shift->get( 'interests', @_ ) } - sub users { return shift->get( 'users', @_ ) } - sub stats { croak 'Unused feature' } + sub stats { croak 'Unused feature' } sub DESTROY { my ($self) = @_; @@ -81,7 +95,7 @@ =head1 VERSION -This document describes Net::OpenAMD version 0.0.1 +This document describes Net::OpenAMD version 0.0.3 =head1 SYNOPSIS @@ -125,7 +139,7 @@ A URL to the API, currently defaults to https://api.hope.net/api/ Most likely it should end with a / to make URI happy, so notice that if you -having 404 errors you don't expect. +are having 404 errors you don't expect. =item ua @@ -166,7 +180,7 @@ =back -Unless specified, there is nothing different about any of the helper methods +Unless specified, there is nothing different about any of the action methods than just calling get($action) instead. Depending on API changes, this may not always be the case.