===================================================================
RCS file: /cvs/todotxt/Text-Todo-REST-API/lib/Text/Todo/REST/API.pm,v
retrieving revision 1.8
retrieving revision 1.13
diff -u -r1.8 -r1.13
--- todotxt/Text-Todo-REST-API/lib/Text/Todo/REST/API.pm	2010/01/19 03:18:34	1.8
+++ todotxt/Text-Todo-REST-API/lib/Text/Todo/REST/API.pm	2010/01/26 04:30:13	1.13
@@ -1,32 +1,23 @@
 package Text::Todo::REST::API;
 
-# $AFresh1: API.pm,v 1.7 2010/01/18 13:47:53 andrew Exp $
+# $AFresh1: API.pm,v 1.12 2010/01/26 03:51:49 andrew Exp $
 
 use warnings;
 use strict;
 use Carp;
 
-use Data::Dumper;
 use Text::Todo;
+use Text::Todo::REST::API::Response;
 
-use Class::Std::Utils;
-use Digest::MD5 qw/ md5_hex /;
-
 use Module::Pluggable
     instantiate => 'new',
-    search_path => __PACKAGE__ . '::Representations',
-    sub_name    => 'representations';
+    search_path => 'Text::Todo::REST::API::Actions',
+    sub_name    => 'actions';
 
+use Class::Std::Utils;
+
 use version; our $VERSION = qv('0.0.1');
 
-&RegisterActionHandler(
-    'GET',
-    [ list  => 'get_list' ],
-    [ entry => 'get_entry' ],
-    [ tags  => 'get_tags' ],
-    [ files => 'get_files' ],
-);
-
 {
     my @attr_refs = \(
         my %todo_of,
@@ -35,10 +26,6 @@
         my %file_regex_of,
 
         my %format_of,
-        my %user_of,
-        my %list_of,
-        my %action_of,
-        my %args_of,
 
         my %action_handlers,
     );
@@ -53,11 +40,6 @@
         if ( $options->{format} ) {
             $format_of{$ident} = $options->{format};
         }
-        elsif ($options->{path_info}
-            && $options->{path_info} =~ s/\.(\w+)$//xms )
-        {
-            $format_of{$ident} = $1;
-        }
 
         $suffix_of{$ident} = $options->{suffix} || '.txt';
 
@@ -69,18 +51,6 @@
             $
         }ixms;
 
-        $options->{path_info} ||= q{};
-        $options->{path_info} =~ s{^/}{}xms;
-        ( $list_of{$ident}, $action_of{$ident}, @{ $args_of{$ident} }, )
-            = split '/', $options->{path_info};
-
-        if ( $list_of{$ident} ) {
-            $action_of{$ident} ||= 'list';
-        }
-        else {
-            $action_of{$ident} = 'files';
-        }
-
         eval {
             $todo_of{$ident} = Text::Todo->new(
                 {   todo_dir  => $options->{todo_dir},
@@ -92,135 +62,140 @@
             $self->fail( 'Unable to create Text::Todo object' . $@ );
         }
 
-        $todo_of{$ident}->load('todo_file')
-            or $self->fail('Unable to load todo_file in Text::Todo object');
-
         return $self;
     }
 
-    sub RegisterActionHandler {
-        my ( $handler, @types ) = @_;
+    sub _parse_options {
+        my ( $self, $method, @args ) = @_;
 
-        foreach my $type (@types) {
-            $action_handlers{$handler}{ $type->[0] } = $type->[1];
-        }
+        my %options = (
+            method => lc $method,
+            list   => '',
+            action => 'files',
+            args   => [],
 
-        return 1;
-    }
+            suffix     => $self->_suffix,
+            file_regex => $self->_file_regex,
+            format     => $self->_format,
+        );
 
-    sub content_type {return}
+        if (@args) {
+            if ( !ref $args[0] ) {
+                $options{path} = shift @args;
+            }
 
-    sub _handle_representation {
-        my ( $self, $type, @args ) = @_;
+            if ( ref $args[0] eq 'HASH' ) {
+                my $opts = shift @args;
+                foreach my $o ( keys %{$opts} ) {
+                    $options{$o} = $opts->{$o};
+                }
+            }
+        }
 
-        my $method = join q{_}, $type, $self->_action;
+        if ( exists $options{path} ) {
+            my %opts = $self->_split_path( $options{path} );
+            delete $options{path};
 
-        foreach my $class ( $self->representations ) {
-            if (   $class->can_format( $self->_format )
-                && $class->can( $method ) )
-            {
-                return $class->$method($self->_format, @args);
+            foreach my $o ( keys %opts ) {
+                if ( defined $opts{$o} ) {
+                    $options{$o} = $opts{$o};
+                }
             }
         }
 
-        return $self->fail(
-            'Unable to ' . $type . ' [' . $self->_action . ']' );
-    }
+        if ( $options{action} eq 'entry' && @{ $options{args} } ) {
+            $options{entry} = shift @{ $options{args} };
+            if ( @{ $options{args} } ) {
+                $options{action} .= q{_} . lc shift @{ $options{args} };
+            }
+        }
 
-    sub Dump {
-        my ( $self, @args ) = @_;
-        return $self->_handle_representation( 'dump', @args );
-    }
+        push @{ $options{args} }, @args;
 
-    sub _handle_action {
-        my ( $self, $method, $params ) = @_;
+        $options{list}
+            = defined $options{list} ? $options{list} : 'todo_file';
 
-        if ( exists $action_handlers{$method}{ $self->_action } ) {
-            my $a = $action_handlers{$method}{ $self->_action };
-            return $self->$a( $self->_args, $params );
+        if ( $options{format} ) {
+            $format_of{ ident $self } = $options{format};
+            delete $options{format};
         }
 
-        return $self->fail(
-            'Unable to handle ' . $method . ' [' . $self->_action . ']' );
+        my @method;
+        foreach my $o qw( method action ) {
+            if ( $options{$o} ) {
+                push @method, $options{$o};
+            }
+        }
+        $method = join q{_}, @method;
+
+        return $method, %options;
     }
 
-    sub GET {
+    sub _handle_action {
         my ( $self, @args ) = @_;
-        return $self->_handle_action( 'GET', @args );
-    }
 
-    sub get_entry {
-        my ( $self, $key ) = @_;
+        my ( $method, %options ) = $self->_parse_options(@args);
 
-        if ( !$key ) {
-            return $self->fail("get_entry requires arguments");
-        }
-        elsif ( ref $key eq 'ARRAY' ) {
-            my @entries;
-            foreach ( @{$key} ) {
-                push @entries, $self->get_entry($_);
+        my $todo = $self->_todo;
+        $todo->load( $options{list} );
+
+        foreach my $class ( $self->actions ) {
+            if ( $class->can($method) ) {
+                return Text::Todo::REST::API::Response->new(
+                    {   type   => $options{action},
+                        format => $self->_format,
+                        data   => $class->$method( $todo, \%options ),
+                    }
+                );
             }
-            return @entries;
         }
 
-        my @list = $self->get_list;
+        return $self->fail( 'Unable to handle [' . $method . ']' );
+    }
 
-        my $entry;
-        if ( $key =~ /^[[:xdigit:]]{32}$/xms ) {
-            my $search = lc $key;
+    sub _split_path {
+        my ( $self, $path ) = @_;
 
-        ENTRY: foreach my $e (@list) {
-                if ( $search eq $e->{md5} ) {
-                    $entry = $e;
-                    last ENTRY;
-                }
-            }
-        }
-        elsif ( $key =~ /^\d+$/xms ) {
-            $entry = $list[ $key - 1 ];
-        }
+        my %options = (
+            list   => undef,
+            action => undef,
+            args   => [],
+        );
 
-        if ( !$entry ) {
-            return $self->fail("Unable to find entry!");
+        $path = defined $path ? $path : q{};
+        $path =~ s{^/}{}xms;
+
+        if ( $path =~ s/\.(\w+)$//xms ) {
+            $options{format} = $1;
         }
 
-        return $entry;
-    }
+        ( $options{list}, $options{action}, @{ $options{args} } ) = split '/',
+            $path;
 
-    sub get_list {
-        my ($self) = @_;
+        if ( $options{list} ) {
+            $options{action} ||= 'list';
 
-        my $line = 1;
-        return map ( {
-                line => $line++,
-                md5  => md5_hex( $_->text ),
-                text => $_->text,
-            },
-            $self->_todo->list );
-    }
+            my $suffix = $self->_suffix;
 
-    sub get_files {
-        my ($self) = @_;
-        my $dir = $self->_todo->file('todo_dir');
+            if ( ( lc $options{list} ) eq 'files' ) {
+                $options{action} = lc $options{list};
+                $options{list}   = q{};
+            }
+            elsif ( $self->_todo->file( $options{list} ) ) {
+                $options{list} = $self->_todo->file( $options{list} );
+            }
+        }
 
-        if ( !$dir ) {
-            return $self->fail('Unable to find todo_dir');
+        if ( @{ $options{args} } && ( lc $options{args}[0] ) eq 'entry' ) {
+            $options{action} = lc shift @{ $options{args} };
         }
 
-        my $file_regex = $self->_file_regex;
-
-        opendir my $dh, $dir or croak "Couldn't opendir: $!";
-        my @files = grep {m/$file_regex/xms} readdir $dh;
-        closedir $dh;
-
-        return @files;
+        return %options;
     }
 
-    sub get_tags {
-        my ( $self, $tag ) = @_;
-        my $ident = ident($self);
-
-        return $todo_of{$ident}->listtag($tag);
+    sub GET {
+        my ( $self, @args ) = @_;
+        return $self->_handle_action( 'GET', @args );
     }
 
     sub POST {
@@ -246,11 +221,7 @@
     sub _todo       { my ($self) = @_; return $todo_of{ ident $self }; }
     sub _suffix     { my ($self) = @_; return $suffix_of{ ident $self}; }
     sub _file_regex { my ($self) = @_; return $file_regex_of{ ident $self}; }
-    sub _user       { my ($self) = @_; return $user_of{ ident $self}; }
-    sub _list       { my ($self) = @_; return $list_of{ ident $self}; }
-    sub _action     { my ($self) = @_; return $action_of{ ident $self}; }
     sub _format     { my ($self) = @_; return $format_of{ ident $self}; }
-    sub _args       { my ($self) = @_; return $args_of{ ident $self}; }
 
     sub DESTROY {
         my ($self) = @_;